sdk/metric: ignore nil ExemplarFilter in WithExemplarFilter#8279
Open
kushalShukla-web wants to merge 3 commits into
Open
sdk/metric: ignore nil ExemplarFilter in WithExemplarFilter#8279kushalShukla-web wants to merge 3 commits into
kushalShukla-web wants to merge 3 commits into
Conversation
kushalShukla-web
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
kushalShukla-web
changed the title
Collaborator
|
I don't think we've made a decision on the issue, which lists two possible resolutions. |
Contributor
There was a problem hiding this comment.
I think this approach makes sense if the decision is to ignore nil filters instead of panicing.
The added nil check looks straightforward, and the extra test cases help cover both the direct nil case and the case where nil is passed after an existing valid filter.
Especially liked the second test since it confirms the previous config isnt getting overwritten accidentally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes : #8240
Hi @dashpole , could you please take a look when you have time?