semconvkit: add invariant test for histogram-exclusion rule#8370
Open
thealpha93 wants to merge 2 commits into
Open
semconvkit: add invariant test for histogram-exclusion rule#8370thealpha93 wants to merge 2 commits into
thealpha93 wants to merge 2 commits into
Conversation
…pes in generated metrics Introduces a test that ensures the semconv code generator does not emit types containing "HistogramObservable" or "ObservableObservable", maintaining compliance with the histogram-exclusion rule. Fixes open-telemetry#8353
thealpha93
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8353.
Adds
TestNoInvalidObservableHistogramTypestointernal/tools/semconvkit/main_test.gothat asserts the histogram-exclusion conditional inmetric.go.j2is never accidentally removed or bypassed.The test walks all
semconv/v1.*/*conv/metric.gofiles and fails ifHistogramObservableorObservableObservableappear in any of them, catching regressions atmake precommittime.Changes
TestNoInvalidObservableHistogramTypesininternal/tools/semconvkit/main_test.goCHANGELOG.md