[dynamic control] refactor TYPE to POLICY_TYPE for clarity (#2720)

Author: jackshirazi

dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/tracesampling/TraceSamplingRatePolicy.java

@@ -8,12 +8,12 @@
 import io.opentelemetry.contrib.dynamic.policy.TelemetryPolicy;
 
 public final class TraceSamplingRatePolicy extends TelemetryPolicy {
-  public static final String TYPE = "trace-sampling";
+  public static final String POLICY_TYPE = "trace-sampling";
 
   private final double probability;
 
   public TraceSamplingRatePolicy(double probability) {
-    super(TYPE);
+    super(POLICY_TYPE);
     if (Double.isNaN(probability) || probability < 0.0 || probability > 1.0) {
       throw new IllegalArgumentException("probability must be within [0.0, 1.0]");
     }

dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/tracesampling/TraceSamplingRatePolicyImplementer.java

@@ -55,7 +55,7 @@ public List<PolicyValidator> getValidators() {
   @Override
   public void onPoliciesChanged(List<TelemetryPolicy> policies) {
     for (TelemetryPolicy policy : policies) {
-      if (!TraceSamplingRatePolicy.TYPE.equals(policy.getType())) {
+      if (!TraceSamplingRatePolicy.POLICY_TYPE.equals(policy.getType())) {
         continue;
       }
       if (!(policy instanceof TraceSamplingRatePolicy)) {

dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/tracesampling/TraceSamplingValidator.java

@@ -21,7 +21,7 @@ public final class TraceSamplingValidator extends AbstractSourcePolicyValidator
 
   @Override
   public String getPolicyType() {
-    return TraceSamplingRatePolicy.TYPE;
+    return TraceSamplingRatePolicy.POLICY_TYPE;
   }
 
   @Override

dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/LinePerPolicyFileProviderTest.java

@@ -9,6 +9,7 @@
 
 import io.opentelemetry.contrib.dynamic.policy.source.SourceFormat;
 import io.opentelemetry.contrib.dynamic.policy.source.SourceWrapper;
+import io.opentelemetry.contrib.dynamic.policy.tracesampling.TraceSamplingRatePolicy;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
@@ -20,7 +21,7 @@
 
 class LinePerPolicyFileProviderTest {
 
-  private static final String TRACE_SAMPLING_TYPE = "trace-sampling";
+  private static final String TRACE_SAMPLING_TYPE = TraceSamplingRatePolicy.POLICY_TYPE;
 
   @TempDir Path tempDir;
 

dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/tracesampling/TraceSamplingRatePolicyImplementerTest.java

@@ -28,7 +28,8 @@ void typeOnlyTraceSamplingPolicyFallsBackToAlwaysOn() {
     TraceSamplingRatePolicyImplementer implementer =
         new TraceSamplingRatePolicyImplementer(delegatingSampler);
 
-    implementer.onPoliciesChanged(singletonList(new TelemetryPolicy("trace-sampling")));
+    implementer.onPoliciesChanged(
+        singletonList(new TelemetryPolicy(TraceSamplingRatePolicy.POLICY_TYPE)));
 
     assertThat(decisionFor(delegatingSampler)).isEqualTo(SamplingDecision.RECORD_AND_SAMPLE);
   }

dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/tracesampling/TraceSamplingValidatorTest.java

@@ -18,7 +18,7 @@
 
 class TraceSamplingValidatorTest {
 
-  private static final String TRACE_SAMPLING_POLICY_TYPE = TraceSamplingRatePolicy.TYPE;
+  private static final String TRACE_SAMPLING_POLICY_TYPE = TraceSamplingRatePolicy.POLICY_TYPE;
 
   private final TraceSamplingValidator validator = new TraceSamplingValidator();