Skip to content

Commit 42d0007

Browse files
committed
fix up attributes
1 parent da05cca commit 42d0007

4 files changed

Lines changed: 2 additions & 7 deletions

File tree

aws-xray/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ dependencies {
1111
api("io.opentelemetry:opentelemetry-sdk-trace")
1212

1313
compileOnly("io.opentelemetry:opentelemetry-sdk-extension-autoconfigure")
14-
implementation("io.opentelemetry.semconv:opentelemetry-semconv:1.40.0")
1514

1615
implementation("com.squareup.okhttp3:okhttp")
1716
implementation("io.opentelemetry.semconv:opentelemetry-semconv")

azure-resources/src/main/java/io/opentelemetry/contrib/azure/resource/AzureAppServiceResourceProvider.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
import static io.opentelemetry.contrib.azure.resource.IncubatingAttributes.CLOUD_REGION;
99
import static io.opentelemetry.contrib.azure.resource.IncubatingAttributes.CLOUD_RESOURCE_ID;
1010
import static io.opentelemetry.contrib.azure.resource.IncubatingAttributes.CloudPlatformIncubatingValues.AZURE_APP_SERVICE;
11-
import static io.opentelemetry.contrib.azure.resource.IncubatingAttributes.DEPLOYMENT_ENVIRONMENT_NAME;
1211
import static io.opentelemetry.contrib.azure.resource.IncubatingAttributes.HOST_ID;
12+
import static io.opentelemetry.semconv.DeploymentAttributes.DEPLOYMENT_ENVIRONMENT_NAME;
1313
import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_INSTANCE_ID;
1414
import static io.opentelemetry.semconv.ServiceAttributes.SERVICE_NAME;
1515
import static java.util.Objects.requireNonNull;

azure-resources/src/main/java/io/opentelemetry/contrib/azure/resource/IncubatingAttributes.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ public static final class CloudProviderIncubatingValues {
3535
private CloudProviderIncubatingValues() {}
3636
}
3737

38-
// deployment attributes
39-
public static final AttributeKey<String> DEPLOYMENT_ENVIRONMENT_NAME =
40-
AttributeKey.stringKey("deployment.environment.name");
41-
4238
// host attributes
4339
public static final AttributeKey<String> HOST_ID = AttributeKey.stringKey("host.id");
4440
public static final AttributeKey<String> HOST_NAME = AttributeKey.stringKey("host.name");

azure-resources/src/test/java/io/opentelemetry/contrib/azure/resource/AzureAppServiceResourceProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
import static io.opentelemetry.semconv.incubating.CloudIncubatingAttributes.CLOUD_PROVIDER;
1313
import static io.opentelemetry.semconv.incubating.CloudIncubatingAttributes.CLOUD_REGION;
1414
import static io.opentelemetry.semconv.incubating.CloudIncubatingAttributes.CLOUD_RESOURCE_ID;
15-
import static io.opentelemetry.semconv.incubating.DeploymentIncubatingAttributes.DEPLOYMENT_ENVIRONMENT_NAME;
15+
import static io.opentelemetry.semconv.DeploymentAttributes.DEPLOYMENT_ENVIRONMENT_NAME;
1616
import static io.opentelemetry.semconv.incubating.HostIncubatingAttributes.HOST_ID;
1717

1818
import com.google.common.collect.ImmutableMap;

0 commit comments

Comments
 (0)