UnnecessarilyFullyQualified

Author: trask

aws-resources/src/main/java/io/opentelemetry/contrib/aws/resource/EcsResource.java

@@ -193,9 +193,7 @@ static void parseResponse(
           DockerImage parsedImage = DockerImage.parse(value);
           if (parsedImage != null) {
             attrBuilders.put(CONTAINER_IMAGE_NAME, parsedImage.getRepository());
-            attrBuilders.put(
-                io.opentelemetry.contrib.aws.resource.IncubatingAttributes.CONTAINER_IMAGE_TAGS,
-                parsedImage.getTag());
+            attrBuilders.put(IncubatingAttributes.CONTAINER_IMAGE_TAGS, parsedImage.getTag());
           }
           break;
         case "ImageID":

buildSrc/src/main/kotlin/otel.errorprone-conventions.gradle.kts

@@ -46,10 +46,6 @@ tasks {
         // Suggests using Guava types for fields but we don't use Guava
         disable("ImmutableMemberCollection")
 
-        // Fully qualified names may be necessary when deprecating a class to avoid
-        // deprecation warning.
-        disable("UnnecessarilyFullyQualified")
-
         // TODO (trask) use animal sniffer
         disable("Java8ApiChecker")
 

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/logs/models/LogRecordDataImpl.java

@@ -12,6 +12,7 @@
 import io.opentelemetry.api.logs.Severity;
 import io.opentelemetry.api.trace.SpanContext;
 import io.opentelemetry.sdk.common.InstrumentationScopeInfo;
+import io.opentelemetry.sdk.logs.data.Body;
 import io.opentelemetry.sdk.logs.data.internal.ExtendedLogRecordData;
 import io.opentelemetry.sdk.resources.Resource;
 import javax.annotation.Nullable;
@@ -24,11 +25,9 @@ public static Builder builder() {
   }
 
   @Deprecated
-  public io.opentelemetry.sdk.logs.data.Body getBody() {
+  public Body getBody() {
     Value<?> valueBody = getBodyValue();
-    return valueBody == null
-        ? io.opentelemetry.sdk.logs.data.Body.empty()
-        : io.opentelemetry.sdk.logs.data.Body.string(valueBody.asString());
+    return valueBody == null ? Body.empty() : Body.string(valueBody.asString());
   }
 
   @Override

disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/spans/models/SpanDataImpl.java

@@ -9,6 +9,7 @@
 import io.opentelemetry.api.common.Attributes;
 import io.opentelemetry.api.trace.SpanContext;
 import io.opentelemetry.api.trace.SpanKind;
+import io.opentelemetry.sdk.common.InstrumentationLibraryInfo;
 import io.opentelemetry.sdk.common.InstrumentationScopeInfo;
 import io.opentelemetry.sdk.resources.Resource;
 import io.opentelemetry.sdk.trace.data.EventData;
@@ -32,7 +33,7 @@ public boolean hasEnded() {
   @SuppressWarnings(
       "deprecation") // Overridden to avoid AutoValue to generate builder method for it.
   @Override
-  public io.opentelemetry.sdk.common.InstrumentationLibraryInfo getInstrumentationLibraryInfo() {
+  public InstrumentationLibraryInfo getInstrumentationLibraryInfo() {
     throw new UnsupportedOperationException();
   }
 

gcp-auth-extension/src/test/java/io/opentelemetry/contrib/gcp/auth/GcpAuthExtensionEndToEndTest.java

@@ -22,6 +22,7 @@
 import java.net.URI;
 import java.security.KeyManagementException;
 import java.security.NoSuchAlgorithmException;
+import java.security.SecureRandom;
 import java.security.cert.X509Certificate;
 import java.time.Duration;
 import java.util.Arrays;
@@ -152,7 +153,7 @@ public X509Certificate[] getAcceptedIssuers() {
           }
         };
     SSLContext sc = SSLContext.getInstance("SSL");
-    sc.init(null, trustAllCerts, new java.security.SecureRandom());
+    sc.init(null, trustAllCerts, new SecureRandom());
     HttpsURLConnection.setDefaultSSLSocketFactory(sc.getSocketFactory());
   }
 

ibm-mq-metrics/src/integrationTest/java/io/opentelemetry/ibm/mq/integration/tests/JakartaPutGet.java

@@ -53,7 +53,7 @@ public static void createQueue(QueueManager manager, String name, int maxDepth)
     MQQueueManager ibmQueueManager = WmqUtil.connectToQueueManager(manager);
     PCFMessageAgent agent = WmqUtil.initPcfMessageAgent(manager, ibmQueueManager);
     PCFMessage request = new PCFMessage(CMQCFC.MQCMD_CREATE_Q);
-    request.addParameter(com.ibm.mq.constants.CMQC.MQCA_Q_NAME, name);
+    request.addParameter(CMQC.MQCA_Q_NAME, name);
     request.addParameter(CMQC.MQIA_Q_TYPE, CMQC.MQQT_LOCAL);
 
     request.addParameter(CMQC.MQIA_MAX_Q_DEPTH, maxDepth);

maven-extension/src/main/java/io/opentelemetry/maven/OtelExecutionListener.java

@@ -98,14 +98,11 @@ public final class OtelExecutionListener extends AbstractExecutionListener {
   public void sessionStarted(ExecutionEvent executionEvent) {
     MavenProject project = executionEvent.getSession().getTopLevelProject();
     TextMapGetter<Map<String, String>> toUpperCaseTextMapGetter = new ToUpperCaseTextMapGetter();
-    io.opentelemetry.context.Context context =
+    Context context =
         openTelemetrySdkService
             .getPropagators()
             .getTextMapPropagator()
-            .extract(
-                io.opentelemetry.context.Context.current(),
-                System.getenv(),
-                toUpperCaseTextMapGetter);
+            .extract(Context.current(), System.getenv(), toUpperCaseTextMapGetter);
 
     // TODO question: is this the root span name we want?
     // It's interesting for the root span name to

maven-extension/src/main/java/io/opentelemetry/maven/handler/MavenDeployHandler.java

@@ -16,6 +16,7 @@
 import java.util.Collections;
 import java.util.List;
 import org.apache.maven.artifact.Artifact;
+import org.apache.maven.artifact.repository.ArtifactRepository;
 import org.apache.maven.execution.ExecutionEvent;
 import org.apache.maven.project.MavenProject;
 import org.slf4j.Logger;
@@ -35,8 +36,7 @@ public void enrichSpan(SpanBuilder spanBuilder, ExecutionEvent execution) {
 
     MavenProject project = execution.getProject();
     @SuppressWarnings("deprecation") // there is no alternative to o.a.m.a.r.ArtifactRepository
-    org.apache.maven.artifact.repository.ArtifactRepository optRepository =
-        project.getDistributionManagementArtifactRepository();
+    ArtifactRepository optRepository = project.getDistributionManagementArtifactRepository();
 
     if (optRepository == null) {
       return;

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/connectivity/http/OkHttpSender.java

@@ -41,7 +41,7 @@ private OkHttpSender(String url, OkHttpClient client) {
   @Override
   public CompletableFuture<Response> send(BodyWriter writer, int contentLength) {
     CompletableFuture<Response> future = new CompletableFuture<>();
-    okhttp3.Request.Builder builder = new okhttp3.Request.Builder().url(url);
+    Request.Builder builder = new Request.Builder().url(url);
     builder.addHeader("Content-Type", CONTENT_TYPE);
 
     RequestBody body = new RawRequestBody(writer, contentLength, MEDIA_TYPE);

opamp-client/src/main/java/io/opentelemetry/opamp/client/internal/connectivity/websocket/OkHttpWebSocket.java

@@ -11,6 +11,7 @@
 import javax.annotation.Nonnull;
 import javax.annotation.Nullable;
 import okhttp3.OkHttpClient;
+import okhttp3.Request;
 import okhttp3.Response;
 import okhttp3.WebSocketListener;
 import okio.ByteString;
@@ -37,7 +38,7 @@ private OkHttpWebSocket(String url, OkHttpClient client) {
   @Override
   public void open(Listener listener) {
     if (status.compareAndSet(Status.NOT_RUNNING, Status.STARTING)) {
-      okhttp3.Request request = new okhttp3.Request.Builder().url(url).build();
+      Request request = new Request.Builder().url(url).build();
       webSocket.set(client.newWebSocket(request, new ListenerAdapter(listener)));
     }
   }