copilot feedback

Author: jackshirazi

dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/registry/PolicyInitConfig.java

@@ -255,17 +255,15 @@ private static DeclarativeConfigProperties getGeneralDeclarativeConfig(
       ConfigProvider configProvider) {
     // Prefer the general config accessor when available in the API/runtime.
     try {
-      Method method = configProvider.getClass().getDeclaredMethod("getGeneralConfig");
-      if (!method.isAccessible()) {
-        method.setAccessible(true);
-      }
+      Method method = configProvider.getClass().getMethod("getGeneralConfig");
       Object maybeConfig = method.invoke(configProvider);
       if (maybeConfig instanceof DeclarativeConfigProperties) {
         return (DeclarativeConfigProperties) maybeConfig;
       }
-    } catch (NoSuchMethodException ignored) {
-      // Fall through to backwards-compatible accessor below.
-    } catch (IllegalAccessException | InvocationTargetException ignored) {
+    } catch (NoSuchMethodException
+        | IllegalAccessException
+        | InvocationTargetException
+        | RuntimeException ignored) {
       // Fall through to backwards-compatible accessor below.
     }
     return configProvider.getGeneralInstrumentationConfig();

dynamic-control/src/test/java/io/opentelemetry/contrib/dynamic/policy/registry/PolicyInitConfigTest.java

@@ -336,6 +336,7 @@ private static DeclarativeConfigProperties mappingConfig() {
     return mapping;
   }
 
+  @SuppressWarnings("EffectivelyPrivate")
   private static final class ConfigProviderWithGeneralConfig implements ConfigProvider {
     private final DeclarativeConfigProperties generalConfig;
 
@@ -349,7 +350,7 @@ public DeclarativeConfigProperties getInstrumentationConfig() {
     }
 
     @SuppressWarnings("unused")
-    DeclarativeConfigProperties getGeneralConfig() {
+    public DeclarativeConfigProperties getGeneralConfig() {
       return generalConfig;
     }
   }