Skip to content

Commit f9d0d14

Browse files
committed
apply jaydeluca review feedback
1 parent c981230 commit f9d0d14

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

dynamic-control/src/main/java/io/opentelemetry/contrib/dynamic/policy/LinePerPolicyFileProvider.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import java.nio.file.Path;
1111
import java.util.ArrayList;
1212
import java.util.List;
13+
import java.util.Objects;
1314
import java.util.logging.Logger;
1415
import java.util.stream.Stream;
1516

@@ -29,7 +30,7 @@
2930
*
3031
* <p>Empty lines and lines starting with <code>#</code> are ignored.
3132
*/
32-
public final class LinePerPolicyFileProvider implements PolicyProvider {
33+
final class LinePerPolicyFileProvider implements PolicyProvider {
3334
private static final Logger logger = Logger.getLogger(LinePerPolicyFileProvider.class.getName());
3435
private final Path file;
3536
private final List<PolicyValidator> validators;
@@ -75,7 +76,14 @@ public List<TelemetryPolicy> fetchPolicies() throws IOException {
7576
for (PolicyValidator validator : validators) {
7677
String alias = validator.getAlias();
7778
if (alias != null && alias.equals(key)) {
78-
policy = validator.validateAlias(key, valueStr);
79+
try {
80+
policy = validator.validateAlias(key, valueStr);
81+
} catch (UnsupportedOperationException e) {
82+
logger.info(
83+
"Validator does not support alias validation: "
84+
+ validator.getClass().getName());
85+
continue;
86+
}
7987
if (policy != null) {
8088
break;
8189
}

0 commit comments

Comments
 (0)