Merged
Conversation
SHA256 is hex encoded, not just digits. Fixes open-telemetry#1788 Signed-off-by: Robert Elliot <rob@lidalia.org.uk>
Contributor
Author
|
Duplicate of #1789 |
Contributor
Contributor
Author
|
OK, reopened |
breedx-splk
approved these changes
May 19, 2025
Contributor
|
I think this is fine, so I approved...but in comparing it with the other PR I'm not sure if we like |
laurit
approved these changes
May 19, 2025
This was referenced Jul 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix ECS image parsing; SHA256 is hex encoded, not just digits.
Existing Issue(s):
#1788
Testing:
Unit test input updated to show the bug
Documentation:
N/A
Outstanding items:
None