Add spotless auto-fix for PRs#1890
Merged
trask merged 3 commits intoopen-telemetry:mainfrom May 19, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
2 times, most recently
from
145d080 to
39c97b8
Compare
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
from
39c97b8 to
787a9dd
Compare
trask
commented
May 17, 2025
breedx-splk
reviewed
May 19, 2025
Comment on lines
+37
to
+38
| - name: Spotless | ||
| run: ./gradlew spotlessApply |
Contributor
There was a problem hiding this comment.
nit: the workflow called spotless-check is the one that runs spotlessApply and the workflow called spotless-apply doesn't. It's only slightly confusing, not a huge deal.
Member
Author
There was a problem hiding this comment.
yeah, it's named more for what you see in the github U/X, I'll probably make it all more generic and rename things again later
Spotless Check runs on PRs, generates the patch file, then Spotless Apply runs afterwards and applies the patch file
breedx-splk
approved these changes
May 19, 2025
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
This seems cool! Thanks.
trask
force-pushed
the
add-spotless-auto-fix-for-prs
branch
from
5368714 to
41cb793
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basically the same as open-telemetry/opentelemetry-java-instrumentation#13872 + open-telemetry/opentelemetry-java-instrumentation#13879.