Update ConfigurableOptions to read from ConfigProperties#1904
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Jun 5, 2025
Merged
Update ConfigurableOptions to read from ConfigProperties#1904trask merged 5 commits intoopen-telemetry:mainfrom
trask merged 5 commits intoopen-telemetry:mainfrom
Conversation
jsuereth
approved these changes
Jun 2, 2025
Contributor
jsuereth
left a comment
There was a problem hiding this comment.
Overall looks good. Capitalization handling - here be dragons. Can you update your goals here for supported environment variable names so it's easier to evaluate if this will break in international contexts?
gcp-auth-extension/src/main/java/io/opentelemetry/contrib/gcp/auth/ConfigurableOption.java
Show resolved
Hide resolved
aabmass
approved these changes
Jun 2, 2025
laurit
approved these changes
Jun 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
GOOGLE_OTEL_AUTH_TARGET_SIGNALS.Existing Issue(s):
Fixes #1903
Testing:
ConfigPropertiesworks as expected.Documentation:
Outstanding items:
Manual testing post merge of Add metrics support to auth extension #1891 .