Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ The extension takes care of the necessary configuration required to authenticate

The future of the [JMX metrics](./jmx-metrics/README.md) component,
built on top of the
[JMX metrics](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/jmx-metrics/javaagent#jmx-metric-insight)
[JMX metrics](https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation/jmx-metrics#jmx-metric-insight)
component from the opentelemetry-java-instrumentation repository.

### Maven extension
Expand Down
2 changes: 1 addition & 1 deletion gcp-resources/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ env:

## Usage with Manual Instrumentation

It is recommended to use this resource detector with the [OpenTelemetry Autoconfiguration SPI](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/autoconfigure/README.md#resource-provider-spi). The GCP resource detector automatically provides the detected resources via the [autoconfigure-spi](https://github.com/open-telemetry/opentelemetry-java/tree/main/sdk-extensions/autoconfigure-spi) SDK extension.
It is recommended to use this resource detector with the [OpenTelemetry SDK autoconfiguration](https://opentelemetry.io/docs/languages/java/configuration/#zero-code-sdk-autoconfigure). The GCP resource detector automatically provides the detected resources via the [autoconfigure-spi](https://opentelemetry.io/docs/languages/java/configuration/#spi-service-provider-interface) SDK extension.

For a reference example showcasing the detected resource attributes and usage with `autoconfigure-spi`, see the [Resource detection example](https://github.com/open-telemetry/opentelemetry-java-examples/tree/main/resource-detection-gcp).

Expand Down
2 changes: 1 addition & 1 deletion jmx-metrics/docs/target-systems/jetty.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Jetty Metrics

The JMX Metric Gatherer provides built in Jetty metric gathering capabilities.
Details about using JMX with WildFly can be found here: https://www.eclipse.org/jetty/documentation/jetty-11/operations-guide/index.html#og-jmx
Details about using JMX with WildFly can be found here: https://jetty.org/docs/jetty/11/operations-guide/jmx/index.html

### Metrics
* Name: `jetty.select.count`
Expand Down
2 changes: 1 addition & 1 deletion jmx-scraper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ This project is released as part of the [OpenTelemetry Java Contrib](https://git
The latest release is available from:

- [GitHub Release assets](https://github.com/open-telemetry/opentelemetry-java-contrib/releases/latest/download/opentelemetry-jmx-scraper.jar)
- [Maven Central](https://central.sonatype.com/artifact/io.opentelemetry.contrib/opentelemetry-jmx-scraper) or can be browsed via [MVN Repository](https://mvnrepository.com/artifact/io.opentelemetry.contrib/opentelemetry-jmx-scraper).
- [Maven Central](https://central.sonatype.com/artifact/io.opentelemetry.contrib/opentelemetry-jmx-scraper)
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the mvnrepository link isn't broken, but they don't allow bots. we could exclude the link from bot checker, but in this case I think the maven central link allows browsing and is what we use elsewhere


## Usage

Expand Down
8 changes: 4 additions & 4 deletions maven-extension/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ The Maven OpenTelemetry Extension is configured using environment variables or J
* (since Maven 3.3.1) configuring the extension in `.mvn/extensions.xml`.

In the code snippets below, replace `OPENTELEMETRY_MAVEN_VERSION` with the [latest
release](https://search.maven.org/search?q=g:io.opentelemetry.contrib%20AND%20a:opentelemetry-maven-extension).
release](https://central.sonatype.com/artifact/io.opentelemetry.contrib/opentelemetry-maven-extension).

### Adding the extension to the classpath

Expand Down Expand Up @@ -109,8 +109,8 @@ In addition to the span attributes captured on every Maven plugin goal executio
|----------------------------------------|--------|-----------------------------------------------------------------------------------------------------------------------------------------------------|
| `http.method` | string | `POST` |
| `http.url` | string | Base URL of the uploaded artifact `${maven.build.repository.url}/${groupId}/${artifactId}/${version}` where the `.` of `${groupId}` are replaced by `/` |
| `maven.build.repository.id` | string | ID of the Maven repository to which the artifact is deployed. See [Maven POM reference / Repository](https://maven.apache.org/pom.html#repository) |
| `maven.build.repository.url` | string | URL of the Maven repository to which the artifact is deployed. See [Maven POM reference / Repository](https://maven.apache.org/pom.html#repository) |
| `maven.build.repository.id` | string | ID of the Maven repository to which the artifact is deployed. See [Maven POM reference / Repository](https://maven.apache.org/pom.html#Repository) |
| `maven.build.repository.url` | string | URL of the Maven repository to which the artifact is deployed. See [Maven POM reference / Repository](https://maven.apache.org/pom.html#Repository) |
| `peer.service` | string | Maven repository hostname deduced from the Repository URL |

The `span.kind` is set to `client`
Expand Down Expand Up @@ -200,7 +200,7 @@ Steps to instrument a Maven Mojo:

* Add the OpenTelemetry API dependency in the `pom.xml` of the Maven plugin.
Replace `OPENTELEMETRY_VERSION` with the [latest
release](https://search.maven.org/search?q=g:io.opentelemetry%20AND%20a:opentelemetry-api).
release](https://central.sonatype.com/artifact/io.opentelemetry/opentelemetry-api).

```xml
<project>
Expand Down
2 changes: 1 addition & 1 deletion samplers/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ The following samplers support [declarative configuration](https://opentelemetry
To use:

* Add a dependency on `io.opentelemetry.contrib:opentelemetry-samplers:<version>`
* Follow the [instructions](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/README.md#file-configuration) to configure OpenTelemetry with declarative configuration.
* Follow the [instructions](https://github.com/open-telemetry/opentelemetry-java/blob/main/sdk-extensions/incubator/README.md#declarative-configuration) to configure OpenTelemetry with declarative configuration.
* Configure the `.tracer_provider.sampler` to include the `rule_based_routing` sampler.

NOTE: Not yet available for use with the OTEL java agent, but should be in the near future. Please check back for updates.
Expand Down
Loading