fix version resolution for semconv#2263
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Sep 15, 2025
Merged
Conversation
Merged
SylvainJuge
reviewed
Sep 15, 2025
|
|
||
| // Version to use to compile code and run tests. | ||
| val DEFAULT_JAVA_VERSION = JavaVersion.VERSION_17 | ||
| val semconvVersion = "1.37.0" |
Contributor
There was a problem hiding this comment.
Do you think we could keep the version in dependencyManagement/build.gradle.kts to keep only having one place where versions are set and updated ? I'm not familiar with gradle resolution details but is there any particular reason we have to do this in otel.java-conventions ?
Member
Author
There was a problem hiding this comment.
it seems to be a bug in gradle dependency resolution - at least I didn't find a way to keep the version where it is now.
@laurit do you have an idea?
Contributor
There was a problem hiding this comment.
I'd replace enforcedPlatform with platform. I fail to see a reason why we should enforce this. cc @trask
Member
Author
There was a problem hiding this comment.
this also doesn't help
configurations.configureEach {
val b = isCanBeResolved && !isCanBeConsumed
println("Configuring $name: add=$b")
if (b || name.startsWith("test")) {
extendsFrom(dependencyManagement)
}
}
Member
Author
|
@laurit it's ready |
laurit
approved these changes
Sep 15, 2025
trask
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found in #2261
This is the problem
Bug remain even when fixing the currently wrong import statement - adding
-alpha