Skip to content

Gradle plugin for generating weaver files#2413

Merged
trask merged 9 commits intoopen-telemetry:mainfrom
jaydeluca:weaver-plugin
Jan 17, 2026
Merged

Gradle plugin for generating weaver files#2413
trask merged 9 commits intoopen-telemetry:mainfrom
jaydeluca:weaver-plugin

Conversation

@jaydeluca
Copy link
Copy Markdown
Member

I took a stab at creating a gradle plugin to replace the makefiles for the weaver generation tasks, inspired by the semantic-conventions-java approach

I imagine this will need to evolve as we figure out the needs of running it for multiple modules (like #2362), aside from just the ibm-mq-metrics, which this was mostly focused on solving for.

I'm still not sure if this is the best approach, there are some others that are still being discussed in open-telemetry/weaver#792 but wanted to see what this might look like

cc @atoulme

@jaydeluca jaydeluca requested a review from a team as a code owner November 3, 2025 01:45
@otelbot-java-contrib
Copy link
Copy Markdown
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

Copy link
Copy Markdown
Contributor

@atoulme atoulme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcmho please review as well

@atoulme
Copy link
Copy Markdown
Contributor

atoulme commented Jan 15, 2026

@jaydeluca please rebase ?

@trask
Copy link
Copy Markdown
Member

trask commented Jan 16, 2026

just double checking y'all ready to have this merged and I'll hit the button

@jaydeluca
Copy link
Copy Markdown
Member Author

just double checking y'all ready to have this merged and I'll hit the button

It's been a while, but i just went back and re-tested everything and its good to go from my perspective.

I just added one more small change to allow invoking the weaverGenerate jobs from anywhere (so you can do ./gradlew :ibm-mq-metrics:generateWeaver from root or ../gradlew :ibm-mq-metrics:generateWeaver from within the ibm-mq-metrics directory

@atoulme @mcmho is this good to go from your perspective?

Copy link
Copy Markdown
Contributor

@mcmho mcmho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a job well done! Thanks for the gradle plugin.

@trask trask added this pull request to the merge queue Jan 17, 2026
Merged via the queue into open-telemetry:main with commit 6994b90 Jan 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants