Gradle task for weaver command#2414
Closed
mcmho wants to merge 10 commits intoopen-telemetry:mainfrom
Closed
Conversation
…try#2072 - created metrics.yaml weaver model - created attriutes.yaml - tested with weaver registry generate
…try#2072 - tested weaver model locally as well as on docker - completed Makefile
…try#2072 - tested weaver model locally as well as on docker - completed Makefile
…try#2072 - fixed the updated desc in JvmIntegrationTest
…try#2072 - fixed the updated desc in JvmIntegrationTest
…try#2072 - fixed the updated desc in JvmIntegrationTest
- directly invoke weaver as a gradle task - removed weaver from Makefile
github-actions
bot
requested review from
SylvainJuge,
breedx-splk and
robsunday
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weaver offers a set of tasks to check and generate code. However, this is typically offered via docker commands orchestrated with a Makefile. Makefile can be obsolete and only solely on gradle task to run weaver.
Existing Issue(s):
This is important to help adoption of a contribution to opentelemetry-java-contrib: #1941
Testing:
gradle task is verified locally
Documentation:
document the new gradle task and what it does