Skip to content

Pin misspell and standardize another renovate config #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurit merged 1 commit into from
Nov 17, 2025
Merged

Pin misspell and standardize another renovate config #2435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/renovate.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
extends: [
'config:best-practices',
'helpers:pinGitHubActionDigestsToSemver',
'customManagers:githubActionsVersions',
Copy link
Copy Markdown
Member Author

@trask trask Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is what will pick up the _VERSION env var in github actions

],
ignorePaths: [], // overwrite default ignore which includes **/test/**
// used to update docker image versions used in Java test files
Expand Down Expand Up @@ -252,8 +253,9 @@
'**/build.gradle.kts',
],
matchStrings: [
'"https://github.com/(?<depName>[^/]+/[^/]+)/zipball/(?<currentValue>.+?)"',
'"(?<currentValue>.+?)" // renovate\\(github-releases\\): (?<depName>[^\\s]+)',
],
versioningTemplate: 'semver',
Comment on lines -255 to +258
Copy link
Copy Markdown
Member Author

@trask trask Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is just aligning with other Java repos

},
{
customType: 'regex',
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/reusable-misspell-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,12 @@ jobs:
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0

- name: Install misspell
env:
# renovate: datasource=github-releases depName=golangci/misspell
MISSPELL_VERSION: v0.7.0
Copy link
Copy Markdown
Member Author

@trask trask Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addresses https://github.com/open-telemetry/opentelemetry-java-contrib/security/code-scanning/107

run: |
curl -sfL https://raw.githubusercontent.com/golangci/misspell/master/install-misspell.sh | sh -s -- -b bin
curl -sfL https://raw.githubusercontent.com/golangci/misspell/${MISSPELL_VERSION}/install-misspell.sh \
| sh -s -- -b bin ${MISSPELL_VERSION}
- name: Run misspell
run: bin/misspell -error .
4 changes: 3 additions & 1 deletion opamp-client/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import java.io.FileOutputStream
import java.io.InputStream
import java.net.URI

val opampSpecVersion = "v0.14.0" // renovate(github-releases): open-telemetry/opamp-spec
Copy link
Copy Markdown
Member Author

@trask trask Nov 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is following the aligned customManager


plugins {
id("otel.java-conventions")
id("otel.publish-conventions")
Expand All @@ -28,7 +30,7 @@ val opampProtos = tasks.register<DownloadAndExtractOpampProtos>("opampProtoDownl
group = "opamp"
outputProtosDir.set(project.layout.buildDirectory.dir("opamp/protos"))
downloadedZipFile.set(project.layout.buildDirectory.file("intermediate/opampProtoDownload/release.zip"))
zipUrl.set("https://github.com/open-telemetry/opamp-spec/zipball/v0.14.0")
zipUrl.set("https://github.com/open-telemetry/opamp-spec/zipball/$opampSpecVersion")
}

wire {
Expand Down