Skip to content

handle profiler being shutdown more than once #2527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurit merged 2 commits into from
Dec 16, 2025
Merged

handle profiler being shutdown more than once #2527

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c9dc4a
handle profiler being shutdown more than once
jackshirazi Dec 16, 2025
7fea4c3
fix warning in compilation
jackshirazi Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...spans/src/main/java/io/opentelemetry/contrib/inferredspans/internal/SamplingProfiler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,8 +454,16 @@ private void profile(Duration profilingDuration) throws Exception {
// dynamically
consumeActivationEventsFromRingBufferAndWriteToFile(profilingDuration);
} finally {
String stopMessage = profiler.execute("stop");
logger.fine(stopMessage);
try {
String stopMessage = profiler.execute("stop");
logger.fine(stopMessage);
} catch (IllegalStateException e) {
if (e.getMessage() != null && e.getMessage().contains("Profiler is not active")) {
logger.fine("Profiler already stopped");
} else {
logger.log(Level.WARNING, "Failure shutting down profiler", e);
}
}
}

// When post-processing is disabled, jfr file will not be parsed and the heavy processing will
Expand Down