Align generate-release-contributors.sh across repos#2590
Merged
trask merged 2 commits intoopen-telemetry:mainfrom Feb 7, 2026
Merged
Align generate-release-contributors.sh across repos#2590trask merged 2 commits intoopen-telemetry:mainfrom
trask merged 2 commits intoopen-telemetry:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns .github/scripts/generate-release-contributors.sh with the version used in other repositories to standardize release contributor generation.
Changes:
- Quote the git revision range when computing the
fromtimestamp. - Update PR-body issue reference extraction regex (now using 4+ digit matches and different delimiters).
- Adjust contributor filtering/output formatting (quote variables; add
codecovexclusion; moverenovateexclusion).
Comment on lines
+72
to
+73
| | grep -oE "#[0-9]{4,}$|#[0-9]{4,}[^0-9<]|$GITHUB_REPOSITORY/issues/[0-9]{4,}" \ | ||
| | grep -oE "[0-9]{4,}" \ |
There was a problem hiding this comment.
The updated issue/PR reference regex can produce false positives and miss valid references:
#[0-9]{4,}[^0-9<]will match HTML numeric entities likeӒ(it will match#1234;), causing the script to query unrelated issues.- Requiring
{4,}digits ignores references to issues/PRs < 1000 (this repo has historical PR numbers < 1000).
Consider restoring the previous delimiter exclusions ([^0-9<&#;]) and using{3,}(or a boundary-based pattern) so entities are ignored while still supporting smaller issue/PR numbers.
laurit
approved these changes
Jan 28, 2026
trask
added a commit
to trask/opentelemetry-java
that referenced
this pull request
Feb 7, 2026
trask
added a commit
to trask/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 7, 2026
trask
added a commit
to trask/semantic-conventions-java
that referenced
this pull request
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.