Skip to content

Update to instrumentation 2.25.0#2625

Merged
jaydeluca merged 8 commits intoopen-telemetry:mainfrom
jaydeluca:update-versino
Feb 18, 2026
Merged

Update to instrumentation 2.25.0#2625
jaydeluca merged 8 commits intoopen-telemetry:mainfrom
jaydeluca:update-versino

Conversation

@jaydeluca
Copy link
Copy Markdown
Member

@jaydeluca jaydeluca commented Feb 13, 2026

supersedes #2624

some internal code was moved around, the compressor SPI replaces the compressorprovider, and updated the disk buffer module to account for the new complex attributes

renovate bot and others added 2 commits February 13, 2026 04:33
@github-actions github-actions bot requested review from PeterF778 and oertl February 13, 2026 12:30
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the OpenTelemetry instrumentation dependency from version 2.24.0-alpha to 2.25.0-alpha, adapting to upstream API changes and internal reorganizations. The update includes three main areas of change: internal class relocations, a migration from CompressorProvider to direct Compressor SPI registration, and comprehensive support for complex attribute types (Value) in the disk buffering module.

Changes:

  • Updated OpenTelemetry instrumentation BOM to 2.25.0-alpha
  • Migrated ZstdCompressor from CompressorProvider pattern to direct SPI registration
  • Added full support for complex Value types (bytes, arrays, key-value lists, nested structures) in disk-buffering attribute serialization

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
dependencyManagement/build.gradle.kts Version bump to 2.25.0-alpha
consistent-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent/ConsistentReservoirSamplingSpanProcessor.java Updated DaemonThreadFactory import path
baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanComponentProvider.java Updated IncludeExcludePredicate import path
baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordComponentProvider.java Updated IncludeExcludePredicate import path
compressors/compressor-zstd/src/main/java/io/opentelemetry/contrib/compressor/zstd/ZstdCompressor.java Removed singleton pattern, changed to public constructor and updated interface import
compressors/compressor-zstd/src/main/java/io/opentelemetry/contrib/compressor/zstd/ZstdCompressorProvider.java Deleted obsolete provider class
compressors/compressor-zstd/src/main/resources/META-INF/services/io.opentelemetry.sdk.common.export.Compressor Added new SPI registration
compressors/compressor-zstd/src/main/resources/META-INF/services/io.opentelemetry.exporter.internal.compression.CompressorProvider Removed old SPI registration
compressors/compressor-zstd/src/test/java/io/opentelemetry/contrib/compressor/zstd/ZstdCompressorTest.java Updated test to instantiate compressor directly
disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/common/AttributesMapper.java Added comprehensive support for Value type serialization including bytes, arrays, key-value lists, and nested structures
disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/testutils/TestData.java Changed empty string to Value.empty()
disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/common/AttributesMapperTest.java Added comprehensive tests for all Value types

@jaydeluca jaydeluca marked this pull request as ready for review February 13, 2026 14:48
@jaydeluca jaydeluca requested a review from a team as a code owner February 13, 2026 14:48
Comment on lines -88 to 174
// Until we have complex attribute types that could potentially yield
// empty objects, we MUST assume here that the writer put an empty string
// into the value of the attribute. This will need to change later, when complex
// types arrive and the spec issue is resolved.
//
// See spec issue: https://github.com/open-telemetry/opentelemetry-specification/issues/4660
// Update after SDK v1.60.0 is released which includes:
// https://github.com/open-telemetry/opentelemetry-java/pull/8014
builder.put(AttributeKey.stringKey(key), "");
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disk buffering / android folks (@LikeTheSalad @zeitlinger @breedx-splk) please review the changes here

in particular, I'm not sure whether you prefer to support complex attributes or not until this bug is fixed

Copy link
Copy Markdown
Contributor

@LikeTheSalad LikeTheSalad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

Copy link
Copy Markdown
Member

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @jaydeluca 👍🏻

@laurit laurit added this pull request to the merge queue Feb 18, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 18, 2026
@jaydeluca jaydeluca added this pull request to the merge queue Feb 18, 2026
Merged via the queue into open-telemetry:main with commit 4ff6c68 Feb 18, 2026
21 checks passed
@jaydeluca jaydeluca deleted the update-versino branch February 18, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants