Update to instrumentation 2.25.0#2625
Conversation
…emetry-instrumentation-bom-alpha to v2.25.0-alpha
There was a problem hiding this comment.
Pull request overview
This PR updates the OpenTelemetry instrumentation dependency from version 2.24.0-alpha to 2.25.0-alpha, adapting to upstream API changes and internal reorganizations. The update includes three main areas of change: internal class relocations, a migration from CompressorProvider to direct Compressor SPI registration, and comprehensive support for complex attribute types (Value) in the disk buffering module.
Changes:
- Updated OpenTelemetry instrumentation BOM to 2.25.0-alpha
- Migrated ZstdCompressor from CompressorProvider pattern to direct SPI registration
- Added full support for complex Value types (bytes, arrays, key-value lists, nested structures) in disk-buffering attribute serialization
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| dependencyManagement/build.gradle.kts | Version bump to 2.25.0-alpha |
| consistent-sampling/src/main/java/io/opentelemetry/contrib/sampler/consistent/ConsistentReservoirSamplingSpanProcessor.java | Updated DaemonThreadFactory import path |
| baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanComponentProvider.java | Updated IncludeExcludePredicate import path |
| baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordComponentProvider.java | Updated IncludeExcludePredicate import path |
| compressors/compressor-zstd/src/main/java/io/opentelemetry/contrib/compressor/zstd/ZstdCompressor.java | Removed singleton pattern, changed to public constructor and updated interface import |
| compressors/compressor-zstd/src/main/java/io/opentelemetry/contrib/compressor/zstd/ZstdCompressorProvider.java | Deleted obsolete provider class |
| compressors/compressor-zstd/src/main/resources/META-INF/services/io.opentelemetry.sdk.common.export.Compressor | Added new SPI registration |
| compressors/compressor-zstd/src/main/resources/META-INF/services/io.opentelemetry.exporter.internal.compression.CompressorProvider | Removed old SPI registration |
| compressors/compressor-zstd/src/test/java/io/opentelemetry/contrib/compressor/zstd/ZstdCompressorTest.java | Updated test to instantiate compressor directly |
| disk-buffering/src/main/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/common/AttributesMapper.java | Added comprehensive support for Value type serialization including bytes, arrays, key-value lists, and nested structures |
| disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/testutils/TestData.java | Changed empty string to Value.empty() |
| disk-buffering/src/test/java/io/opentelemetry/contrib/disk/buffering/internal/serialization/mapping/common/AttributesMapperTest.java | Added comprehensive tests for all Value types |
...telemetry/contrib/disk/buffering/internal/serialization/mapping/common/AttributesMapper.java
Outdated
Show resolved
Hide resolved
...telemetry/contrib/disk/buffering/internal/serialization/mapping/common/AttributesMapper.java
Show resolved
Hide resolved
| // Until we have complex attribute types that could potentially yield | ||
| // empty objects, we MUST assume here that the writer put an empty string | ||
| // into the value of the attribute. This will need to change later, when complex | ||
| // types arrive and the spec issue is resolved. | ||
| // | ||
| // See spec issue: https://github.com/open-telemetry/opentelemetry-specification/issues/4660 | ||
| // Update after SDK v1.60.0 is released which includes: | ||
| // https://github.com/open-telemetry/opentelemetry-java/pull/8014 | ||
| builder.put(AttributeKey.stringKey(key), ""); |
There was a problem hiding this comment.
disk buffering / android folks (@LikeTheSalad @zeitlinger @breedx-splk) please review the changes here
in particular, I'm not sure whether you prefer to support complex attributes or not until this bug is fixed
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Thanks for working on this @jaydeluca 👍🏻
supersedes #2624
some internal code was moved around, the compressor SPI replaces the compressorprovider, and updated the disk buffer module to account for the new complex attributes