Skip running tests in build step#2651
Merged
jaydeluca merged 1 commit intoopen-telemetry:mainfrom Feb 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the issue where -x test doesn't properly skip JvmTestSuites that are added to the check task with dependsOn. It introduces a property-based approach to disable all Test tasks consistently across the build.
Changes:
- Added a
skipTestsproperty handler in root build.gradle.kts that disables all Test tasks when set to true - Updated the build-common.yml workflow to use
-PskipTests=trueinstead of-x test
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| build.gradle.kts | Added property-based mechanism to disable all Test tasks including JvmTestSuites when skipTests=true is passed |
| .github/workflows/build-common.yml | Updated build step to use -PskipTests=true instead of -x test to properly skip all test tasks |
|
|
||
| - name: Build | ||
| run: ./gradlew build -x spotlessCheck -x test ${{ inputs.no-build-cache && '--no-build-cache' || '' }} | ||
| run: ./gradlew build -x spotlessCheck -PskipTests=true ${{ inputs.no-build-cache && '--no-build-cache' || '' }} |
There was a problem hiding this comment.
The copilot-setup-steps.yml workflow also uses -x test and should be updated to use -PskipTests=true for consistency. This ensures that all test suites (including JvmTestSuites added with dependsOn to check) are properly skipped across all workflows.
jaydeluca
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are already run in separate test steps.
-x testwon't skip jvm test suites that are added withdependsOntocheck.