Skip to content

Add the MQ metrics shaded jar to the release artifacts #2682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
breedx-splk merged 1 commit into from
Mar 13, 2026
Merged

Add the MQ metrics shaded jar to the release artifacts #2682

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ jobs:
run: |
mkdir -p jmx-metrics/build/libs
mkdir -p jmx-scraper/build/libs
mkdir -p ibm-mq-metrics/build/libs

curl -L -o jmx-metrics/build/libs/opentelemetry-jmx-metrics-$VERSION-alpha.jar \
"https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-metrics/$VERSION-alpha/opentelemetry-jmx-metrics-$VERSION-alpha.jar"
Expand All @@ -117,6 +118,10 @@ jobs:
"https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/$VERSION-alpha/opentelemetry-jmx-scraper-$VERSION-alpha.jar"
curl -L -o jmx-scraper/build/libs/opentelemetry-jmx-scraper-$VERSION-alpha.jar.asc \
"https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-jmx-scraper/$VERSION-alpha/opentelemetry-jmx-scraper-$VERSION-alpha.jar.asc"
curl -L -o ibm-mq-metrics/build/libs/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar \
"https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-ibm-mq-metrics/$VERSION-alpha/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar"
curl -L -o ibm-mq-metrics/build/libs/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar.asc \
"https://repo1.maven.org/maven2/io/opentelemetry/contrib/opentelemetry-ibm-mq-metrics/$VERSION-alpha/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar.asc"
Comment on lines +121 to +124
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new curl downloads for the IBM MQ shaded JAR don’t use --fail (or equivalent). If Maven Central returns a 404/5xx HTML response, curl can still exit successfully and you’ll end up attaching an invalid file to the GitHub release. Consider adding --fail --show-error (and optionally retries) to these downloads (and ideally keep the behavior consistent with the other artifact downloads in this step).

Copilot uses AI. Check for mistakes.

- name: Generate release notes
env:
Expand Down Expand Up @@ -165,12 +170,15 @@ jobs:
cp jmx-metrics/build/libs/opentelemetry-jmx-metrics-$VERSION-alpha.jar.asc opentelemetry-jmx-metrics.jar.asc
cp jmx-scraper/build/libs/opentelemetry-jmx-scraper-$VERSION-alpha.jar opentelemetry-jmx-scraper.jar
cp jmx-scraper/build/libs/opentelemetry-jmx-scraper-$VERSION-alpha.jar.asc opentelemetry-jmx-scraper.jar.asc
cp ibm-mq-metrics/build/libs/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar opentelemetry-ibm-mq-metrics-all.jar
cp ibm-mq-metrics/build/libs/opentelemetry-ibm-mq-metrics-$VERSION-alpha-all.jar.asc opentelemetry-ibm-mq-metrics-all.jar.asc

- uses: actions/attest-build-provenance@a2bbfa25375fe432b6a289bc6b6cd05ecd0c4c32 # v4.1.0
with:
subject-path: |
opentelemetry-jmx-metrics.jar
opentelemetry-jmx-scraper.jar
opentelemetry-ibm-mq-metrics-all.jar

- id: create-github-release
name: Create GitHub release
Expand All @@ -184,7 +192,9 @@ jobs:
opentelemetry-jmx-metrics.jar \
opentelemetry-jmx-metrics.jar.asc \
opentelemetry-jmx-scraper.jar \
opentelemetry-jmx-scraper.jar.asc
opentelemetry-jmx-scraper.jar.asc \
opentelemetry-ibm-mq-metrics-all.jar \
opentelemetry-ibm-mq-metrics-all.jar.asc

# these are used as job outputs
echo "version=$VERSION" >> $GITHUB_OUTPUT
Expand Down
Loading