Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
import io.opentelemetry.contrib.dynamic.policy.TelemetryPolicy;

public final class TraceSamplingRatePolicy extends TelemetryPolicy {
public static final String TYPE = "trace-sampling";
public static final String POLICY_TYPE = "trace-sampling";

private final double probability;

public TraceSamplingRatePolicy(double probability) {
super(TYPE);
super(POLICY_TYPE);
if (Double.isNaN(probability) || probability < 0.0 || probability > 1.0) {
throw new IllegalArgumentException("probability must be within [0.0, 1.0]");
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public List<PolicyValidator> getValidators() {
@Override
public void onPoliciesChanged(List<TelemetryPolicy> policies) {
for (TelemetryPolicy policy : policies) {
if (!TraceSamplingRatePolicy.TYPE.equals(policy.getType())) {
if (!TraceSamplingRatePolicy.POLICY_TYPE.equals(policy.getType())) {
continue;
}
if (!(policy instanceof TraceSamplingRatePolicy)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public final class TraceSamplingValidator extends AbstractSourcePolicyValidator

@Override
public String getPolicyType() {
return TraceSamplingRatePolicy.TYPE;
return TraceSamplingRatePolicy.POLICY_TYPE;
}

@Override
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

import io.opentelemetry.contrib.dynamic.policy.source.SourceFormat;
import io.opentelemetry.contrib.dynamic.policy.source.SourceWrapper;
import io.opentelemetry.contrib.dynamic.policy.tracesampling.TraceSamplingRatePolicy;
import java.io.IOException;
import java.nio.file.Files;
import java.nio.file.Path;
Expand All @@ -20,7 +21,7 @@

class LinePerPolicyFileProviderTest {

private static final String TRACE_SAMPLING_TYPE = "trace-sampling";
private static final String TRACE_SAMPLING_TYPE = TraceSamplingRatePolicy.POLICY_TYPE;

@TempDir Path tempDir;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ void typeOnlyTraceSamplingPolicyFallsBackToAlwaysOn() {
TraceSamplingRatePolicyImplementer implementer =
new TraceSamplingRatePolicyImplementer(delegatingSampler);

implementer.onPoliciesChanged(singletonList(new TelemetryPolicy("trace-sampling")));
implementer.onPoliciesChanged(
singletonList(new TelemetryPolicy(TraceSamplingRatePolicy.POLICY_TYPE)));

assertThat(decisionFor(delegatingSampler)).isEqualTo(SamplingDecision.RECORD_AND_SAMPLE);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@

class TraceSamplingValidatorTest {

private static final String TRACE_SAMPLING_POLICY_TYPE = TraceSamplingRatePolicy.TYPE;
private static final String TRACE_SAMPLING_POLICY_TYPE = TraceSamplingRatePolicy.POLICY_TYPE;

private final TraceSamplingValidator validator = new TraceSamplingValidator();

Expand Down
Loading