add toString implementation in the baggage processor#2800
Merged
Conversation
SylvainJuge
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds toString() implementations to baggage processors so SDK configuration dumps include the include/exclude predicate details, improving debuggability and enabling stronger configuration assertions in tests.
Changes:
- Implement
toString()inBaggageSpanProcessorandBaggageLogRecordProcessordelegating to the configured predicate. - Strengthen declarative configuration tests to assert include/exclude patterns appear in the SDK string output.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanProcessor.java | Adds toString() including the baggageKeyPredicate value. |
| baggage-processor/src/main/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordProcessor.java | Adds toString() including the baggageKeyPredicate value. |
| baggage-processor/src/test/java/io/opentelemetry/contrib/baggage/processor/BaggageSpanComponentProviderTest.java | Updates assertion to check predicate include/exclude details appear in SDK dump. |
| baggage-processor/src/test/java/io/opentelemetry/contrib/baggage/processor/BaggageLogRecordComponentProviderTest.java | Updates assertion to check predicate include/exclude details appear in SDK dump. |
laurit
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of
BaggageLogRecordProcessorandBaggageSpanProcessordo not implementtoStringwhich makes testing and debugging configuration harder, in particular when using declarative configuration.This PR adds a simple implementation that delegates to the underlying
IncludeExcludePredicateso we get the include/exclude patterns used in thetoStringresult.