Skip to content

Remove duplicate dependency#2808

Merged
trask merged 1 commit into
open-telemetry:mainfrom
trask:remove-unnecessary
May 1, 2026
Merged

Remove duplicate dependency#2808
trask merged 1 commit into
open-telemetry:mainfrom
trask:remove-unnecessary

Conversation

@trask
Copy link
Copy Markdown
Member

@trask trask commented Apr 30, 2026

Noticed in #2806 (which should get autoclosed after this is merged)

Copilot AI review requested due to automatic review settings April 30, 2026 21:58
@trask trask requested a review from a team as a code owner April 30, 2026 21:58
Comment thread aws-xray/build.gradle.kts
implementation("io.opentelemetry.semconv:opentelemetry-semconv:1.40.0")

implementation("com.squareup.okhttp3:okhttp")
implementation("io.opentelemetry.semconv:opentelemetry-semconv")
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^ here's the duplicate

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a redundant, version-pinned opentelemetry-semconv dependency from the aws-xray module so the module relies on the repo’s centralized dependency management (avoiding duplicate declarations and helping dependency update PRs apply cleanly).

Changes:

  • Removed the explicit io.opentelemetry.semconv:opentelemetry-semconv:1.40.0 dependency line from aws-xray.
  • Kept the unversioned io.opentelemetry.semconv:opentelemetry-semconv dependency so the version is sourced from the shared platform.

@breedx-splk breedx-splk enabled auto-merge April 30, 2026 22:07
@breedx-splk breedx-splk added this pull request to the merge queue Apr 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2026
@trask trask added this pull request to the merge queue May 1, 2026
Merged via the queue into open-telemetry:main with commit 638aca3 May 1, 2026
24 checks passed
@trask trask deleted the remove-unnecessary branch May 1, 2026 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants