Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR deprecates the EventToSpanEventBridge (and its declarative config component provider) in processors, guiding users to the replacement that’s being moved into opentelemetry-java.
Changes:
- Mark
EventToSpanEventBridgeas@Deprecatedand add Javadoc guidance pointing toio.opentelemetry.sdk.extension.incubator.logs.EventToSpanEventBridge. - Deprecate the internal
EventToSpanEventBridgeComponentProviderused for declarative config SPI. - Add a warning note to
processors/README.mdand suppress deprecation warnings where the deprecated type is referenced in tests/SPI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| processors/src/test/java/io/opentelemetry/contrib/eventbridge/EventToSpanEventBridgeTest.java | Suppresses deprecation warnings for tests that reference the deprecated bridge. |
| processors/src/main/java/io/opentelemetry/contrib/eventbridge/internal/EventToSpanEventBridgeComponentProvider.java | Deprecates the declarative config SPI provider and suppresses deprecation warnings. |
| processors/src/main/java/io/opentelemetry/contrib/eventbridge/EventToSpanEventBridge.java | Deprecates the bridge and documents the recommended replacement artifact/class. |
| processors/README.md | Adds a prominent deprecation warning and migration guidance. |
| @@ -38,6 +38,7 @@ | |||
| import java.util.concurrent.TimeUnit; | |||
| import org.junit.jupiter.api.Test; | |||
|
|
|||
Comment on lines
+21
to
23
| @Deprecated | ||
| @SuppressWarnings("deprecation") | ||
| public class EventToSpanEventBridgeComponentProvider implements ComponentProvider { |
trask
approved these changes
May 5, 2026
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving to opentelemetry-java in open-telemetry/opentelemetry-java#8372