Code review sweep (run 25176007766) (#18447)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>

Author: otelbot[bot]

instrumentation/jaxrs/jaxrs-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/HandlerData.java

@@ -120,7 +120,7 @@ private static Method findMatchingMethod(Method baseMethod, Method[] methods) {
     return null;
   }
 
-  private static String buildSpanName(String classPath, String methodPath) {
+  private static String buildSpanName(@Nullable String classPath, @Nullable String methodPath) {
     StringBuilder spanNameBuilder = new StringBuilder();
     boolean skipSlash = false;
     if (classPath != null) {

instrumentation/jaxrs/jaxrs-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxrs/JaxrsPathUtil.java

@@ -5,8 +5,10 @@
 
 package io.opentelemetry.javaagent.instrumentation.jaxrs;
 
+import javax.annotation.Nullable;
+
 public class JaxrsPathUtil {
-  public static String normalizePath(String path) {
+  public static String normalizePath(@Nullable String path) {
     // ensure that non-empty path starts with /
     if (path == null || path.equals("/")) {
       path = "";

instrumentation/jaxws/jaxws-2.0-axis2-1.6/javaagent/build.gradle.kts

@@ -54,7 +54,7 @@ configurations.configureEach {
   }
 }
 
-tasks.withType<Test>().configureEach {
+tasks.test {
   // required on jdk17
   jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
   jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")

instrumentation/jaxws/jaxws-2.0-tomee-testing/build.gradle.kts

@@ -21,7 +21,7 @@ otelJava {
   maxJavaVersionForTests.set(JavaVersion.VERSION_23)
 }
 
-tasks.withType<Test>().configureEach {
+tasks.test {
   // required on jdk17
   jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
   jvmArgs("--add-exports=java.base/sun.misc=ALL-UNNAMED")

instrumentation/jaxws/jaxws-2.0-wildfly-testing/build.gradle.kts

@@ -54,6 +54,10 @@ tasks {
 
     // needed for java 11 to avoid org.jboss.modules.ModuleNotFoundException: java.se
     jvmArgs("--add-modules=java.se")
+    // required on jdk17
+    jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
+    jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")
+    jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
     // add offset to default port values
     jvmArgs("-Djboss.socket.binding.port-offset=200")
 
@@ -63,10 +67,3 @@ tasks {
     }.plus(files(layout.buildDirectory.file("tmp/logback-classic-modified.jar")))
   }
 }
-
-tasks.withType<Test>().configureEach {
-  // required on jdk17
-  jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
-  jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")
-  jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
-}

instrumentation/jaxws/jaxws-2.0/javaagent/build.gradle.kts

@@ -16,7 +16,7 @@ dependencies {
   implementation(project(":instrumentation:jaxws:jaxws-common:javaagent"))
 }
 
-tasks.withType<Test>().configureEach {
+tasks.test {
   jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
   systemProperty("collectMetadata", otelProps.collectMetadata)
   systemProperty("metadataConfig", "otel.instrumentation.common.experimental.controller-telemetry.enabled=true")

instrumentation/jaxws/jaxws-3.0-axis2-2.0-testing/build.gradle.kts

@@ -22,6 +22,6 @@ otelJava {
   minJavaVersionSupported.set(JavaVersion.VERSION_17)
 }
 
-tasks.withType<Test>().configureEach {
+tasks.test {
   jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
 }

instrumentation/jaxws/jaxws-3.0-cxf-4.0-testing/build.gradle.kts

@@ -19,6 +19,6 @@ otelJava {
   minJavaVersionSupported.set(JavaVersion.VERSION_17)
 }
 
-tasks.withType<Test>().configureEach {
+tasks.test {
   jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
 }

instrumentation/jaxws/jaxws-3.0-metro-3.0-testing/build.gradle.kts

@@ -18,7 +18,7 @@ otelJava {
   minJavaVersionSupported.set(JavaVersion.VERSION_17)
 }
 
-tasks.withType<Test>().configureEach {
+tasks.test {
   // required on jdk17
   jvmArgs("--add-opens=java.base/java.lang=ALL-UNNAMED")
   jvmArgs("-XX:+IgnoreUnrecognizedVMOptions")

instrumentation/jaxws/jaxws-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jaxws/common/JaxWsCodeAttributesGetter.java

@@ -7,7 +7,7 @@
 
 import io.opentelemetry.instrumentation.api.incubator.semconv.code.CodeAttributesGetter;
 
-final class JaxWsCodeAttributesGetter implements CodeAttributesGetter<JaxWsRequest> {
+class JaxWsCodeAttributesGetter implements CodeAttributesGetter<JaxWsRequest> {
 
   @Override
   public Class<?> getCodeClass(JaxWsRequest request) {