Skip to content

Commit 06f218a

Browse files
committed
fix
1 parent 14e0263 commit 06f218a

4 files changed

Lines changed: 27 additions & 10 deletions

File tree

.github/config/latest-dep-versions.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,7 @@
306306
"org.apache.pekko:pekko-http_2.12#+": "1.3.0",
307307
"org.apache.pekko:pekko-http_2.13#+": "1.3.0",
308308
"org.apache.pekko:pekko-http_3#+": "1.3.0",
309+
"org.apache.pekko:pekko-slf4j_2.13#+": "1.5.0",
309310
"org.apache.pekko:pekko-stream_2.12#+": "1.4.0",
310311
"org.apache.pekko:pekko-stream_2.13#+": "1.5.0",
311312
"org.apache.pulsar:pulsar-client#+": "4.2.1",

conventions/src/main/kotlin/io.opentelemetry.instrumentation.base.gradle.kts

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -170,14 +170,19 @@ configurations {
170170
// configurations stay safe by default.
171171
configureEach {
172172
if (!isCanBeResolved) return@configureEach
173-
// `latestDepTestLibrary` overrides apply ONLY to test-classpath configurations.
174-
// They must NOT touch `compileClasspath`, because the whole point of `library(old)` +
175-
// `latestDepTestLibrary(newRange)` is to keep the agent compiling against the old API
176-
// while testing against the new one. Forcing the override onto compileClasspath would
177-
// upgrade the compileOnly `library(...)` version and break compilation (e.g.
178-
// scala-fork-join-2.8 compiles against scala 2.8 APIs, vertx-sql-client-4.0 against
179-
// generic vertx 4.0 APIs, elasticsearch-transport-5.0 against generic ES 5.0 APIs).
180-
val applyOverrides = name.contains("test", ignoreCase = true)
173+
// `latestDepTestLibrary` overrides apply ONLY to the main test/latestDepTest
174+
// configurations. They must NOT touch `compileClasspath`, because the whole point of
175+
// `library(old)` + `latestDepTestLibrary(newRange)` is to keep the agent compiling
176+
// against the old API while testing against the new one. Forcing the override onto
177+
// compileClasspath would upgrade the compileOnly `library(...)` version and break
178+
// compilation (e.g. scala-fork-join-2.8 compiles against scala 2.8 APIs,
179+
// vertx-sql-client-4.0 against generic vertx 4.0 APIs, elasticsearch-transport-5.0
180+
// against generic ES 5.0 APIs). Overrides must also NOT touch custom JvmTestSuite
181+
// source sets (e.g. `play24Test*`, `version20Test*`, `tapirTest*`) which declare
182+
// their own explicit older versions; using `contains("test")` here would let the
183+
// main suite's `latestDepTestLibrary("...:2.5.+")` upgrade play-mvc-2.4's
184+
// `play24Test` classpath off Play 2.4. Use a strict prefix match instead.
185+
val applyOverrides = name.startsWith("test") || name.startsWith("latestDepTest")
181186
// Pinning of `latest.release`/`+` versions is applied across test-related
182187
// configurations and the main `compileClasspath`. compileClasspath is included so
183188
// that modules whose `library(...)` declarations resolve `latest.release` in latest

instrumentation/kubernetes-client-7.0/javaagent/build.gradle.kts

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,20 @@ dependencies {
2121

2222
testing {
2323
suites {
24-
val version20Test by registering(JvmTestSuite::class) {
24+
// version22Test reuses the same test source against `latest.release` in latest-deps mode
25+
// (currently 26.x), and against 22.0.0 otherwise, to exercise the upper end of the v20+
26+
// builder API line.
27+
val version22Test by registering(JvmTestSuite::class) {
28+
sources {
29+
java {
30+
setSrcDirs(listOf("src/version20Test/java"))
31+
}
32+
}
2533
dependencies {
2634
if (otelProps.testLatestDeps) {
2735
implementation("io.kubernetes:client-java-api:latest.release")
2836
} else {
29-
implementation("io.kubernetes:client-java-api:20.0.0")
37+
implementation("io.kubernetes:client-java-api:22.0.0")
3038
}
3139
}
3240
}

instrumentation/pekko/pekko-http-1.0/javaagent/build.gradle.kts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ testing {
7171
implementation("com.typesafe.akka:akka-http_2.13:latest.release")
7272
implementation("com.typesafe.akka:akka-stream_2.13:latest.release")
7373
implementation("com.softwaremill.sttp.tapir:tapir-pekko-http-server_2.13:latest.release")
74+
implementation("org.apache.pekko:pekko-actor_2.13:latest.release")
75+
implementation("org.apache.pekko:pekko-stream_2.13:latest.release")
76+
implementation("org.apache.pekko:pekko-slf4j_2.13:latest.release")
7477
} else {
7578
implementation("org.apache.pekko:pekko-http_2.12:1.0.0")
7679
implementation("org.apache.pekko:pekko-stream_2.12:1.0.1")

0 commit comments

Comments
 (0)