Skip to content

Commit 0a09fd5

Browse files
committed
system fallback for span name
1 parent 25fd8e6 commit 0a09fd5

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcSpanNameExtractor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,13 @@ public final class RpcSpanNameExtractor<REQUEST> implements SpanNameExtractor<RE
1616
* conventions: {@code <rpc.service>/<rpc.method>}.
1717
*/
1818
public static <REQUEST> SpanNameExtractor<REQUEST> create(
19-
RpcAttributesGetter<REQUEST, Object> attributesExtractor) {
19+
RpcAttributesGetter<REQUEST, ?> attributesExtractor) {
2020
return new RpcSpanNameExtractor<>(attributesExtractor);
2121
}
2222

23-
private final RpcAttributesGetter<REQUEST, Object> getter;
23+
private final RpcAttributesGetter<REQUEST, ?> getter;
2424

25-
private RpcSpanNameExtractor(RpcAttributesGetter<REQUEST, Object> getter) {
25+
private RpcSpanNameExtractor(RpcAttributesGetter<REQUEST, ?> getter) {
2626
this.getter = getter;
2727
}
2828

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/internal/SemconvStability.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -189,13 +189,13 @@ public static AttributeKey<String> getOldRpcMethodAttributeKey() {
189189
return RPC_METHOD;
190190
}
191191

192-
private SemconvStability() {}
193-
194192
public static Attributes getOldRpcMetricAttributes(Attributes attributes) {
195193
if (emitStableRpcSemconv()) {
196194
// need to copy attributes
197195
return attributes.toBuilder().put(RPC_METHOD, attributes.get(RPC_METHOD_OLD)).build();
198196
}
199197
return attributes;
200198
}
199+
200+
private SemconvStability() {}
201201
}

0 commit comments

Comments
 (0)