Skip to content

Commit 0f6b98d

Browse files
lauritCopilot
andauthored
Disable kafka metrics by default in v3 (#18828)
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
1 parent 4bb6468 commit 0f6b98d

2 files changed

Lines changed: 8 additions & 0 deletions

File tree

instrumentation/kafka/kafka-clients/kafka-clients-0.11/javaagent/build.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,8 @@ tasks {
7777
jvmArgs("-Dotel.instrumentation.messaging.experimental.receive-telemetry.enabled=true")
7878
jvmArgs("-Dotel.semconv-stability.preview=messaging")
7979
jvmArgs("-Dotel.instrumentation.common.v3-preview=true")
80+
// kafka metrics are disabled by default with v3-preview enabled
81+
jvmArgs("-Dotel.instrumentation.kafka-clients-metrics.enabled=true")
8082
systemProperty("metadataConfig", "otel.semconv-stability.opt-in=messaging")
8183
}
8284

instrumentation/kafka/kafka-clients/kafka-clients-0.11/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kafkaclients/v0_11/metrics/KafkaMetricsInstrumentationModule.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import static java.util.Collections.singletonList;
1010

1111
import com.google.auto.service.AutoService;
12+
import io.opentelemetry.javaagent.bootstrap.internal.AgentCommonConfig;
1213
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1314
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1415
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
@@ -37,4 +38,9 @@ public List<TypeInstrumentation> typeInstrumentations() {
3738
return asList(
3839
new KafkaMetricsProducerInstrumentation(), new KafkaMetricsConsumerInstrumentation());
3940
}
41+
42+
@Override
43+
public boolean defaultEnabled() {
44+
return super.defaultEnabled() && !AgentCommonConfig.get().isV3Preview();
45+
}
4046
}

0 commit comments

Comments
 (0)