Skip to content

Commit 166812f

Browse files
committed
Review fixes for async-http-client-2.0:javaagent
Automated code review of instrumentation/async-http-client/async-http-client-2.0/javaagent.
1 parent 5e372ad commit 166812f

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

instrumentation/async-http-client/async-http-client-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v2_0/CompletableFutureWrapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111

1212
public class CompletableFutureWrapper {
1313

14-
private CompletableFutureWrapper() {}
15-
1614
public static <T> CompletableFuture<T> wrap(CompletableFuture<T> future, Context context) {
1715
CompletableFuture<T> result = new CompletableFuture<>();
1816
future.whenComplete(
@@ -28,4 +26,6 @@ public static <T> CompletableFuture<T> wrap(CompletableFuture<T> future, Context
2826

2927
return result;
3028
}
29+
30+
private CompletableFutureWrapper() {}
3131
}

instrumentation/async-http-client/async-http-client-2.0/metadata.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,19 @@ semantic_conventions:
88
- HTTP_CLIENT_METRICS
99
configurations:
1010
- name: otel.instrumentation.http.known-methods
11+
declarative_name: java.common.http.known_methods
1112
description: >
1213
Configures the instrumentation to recognize an alternative set of HTTP request methods. All
1314
other methods will be treated as `_OTHER`.
1415
type: list
1516
default: "CONNECT,DELETE,GET,HEAD,OPTIONS,PATCH,POST,PUT,TRACE"
1617
- name: otel.instrumentation.http.client.capture-request-headers
18+
declarative_name: general.http.client.request_captured_headers
1719
description: List of HTTP request headers to capture in HTTP client telemetry.
1820
type: list
1921
default: ""
2022
- name: otel.instrumentation.http.client.capture-response-headers
23+
declarative_name: general.http.client.response_captured_headers
2124
description: List of HTTP response headers to capture in HTTP client telemetry.
2225
type: list
2326
default: ""
@@ -26,13 +29,15 @@ configurations:
2629
type: map
2730
default: ""
2831
- name: otel.instrumentation.http.client.emit-experimental-telemetry
32+
declarative_name: java.common.http.client.emit_experimental_telemetry/development
2933
description: >
3034
Enable the capture of experimental HTTP client telemetry. Adds the `http.request.body.size`
3135
and `http.response.body.size` attributes to spans, and records `http.client.request.size` and
3236
`http.client.response.size` metrics.
3337
type: boolean
3438
default: false
3539
- name: otel.instrumentation.sanitization.url.experimental.sensitive-query-parameters
40+
declarative_name: general.sanitization.url.sensitive_query_parameters/development
3641
description: List of URL query parameter names whose values are redacted in URL attributes. See https://opentelemetry.io/docs/specs/semconv/http/http-spans.
3742
type: list
3843
default: "AWSAccessKeyId,Signature,sig,X-Goog-Signature"

0 commit comments

Comments
 (0)