Remove CommandSchedulerInstrumentation and fix null connectOptions check

CommandSchedulerInstrumentation interfered with Vert.x async context
propagation, breaking traces for all pool-based queries (spans ended up
in separate traces instead of sharing the parent trace).

The 'if (connectOptions == null) return' check in QueryAdvice skipped
span creation for ALL pooled connections, not just JDBC-backed ones.
Pool is an interface with static pool() methods -- the PoolAdvice type
matcher (implementsInterface) matches implementing classes which don't
have those static methods, so PoolAdvice never fires and connectOptions
are always null for the pool path.

Also removes VertxJdbcClientTest since the JDBC suppression mechanism
(null connectOptions check) was fundamentally broken.

Author: trask

instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/CommandSchedulerInstrumentation.java

@@ -104,12 +104,6 @@ public static AdviceScope start(Object queryExecutor, Object[] arguments) {
         }
 
         SqlConnectOptions connectOptions = QueryExecutorUtil.getConnectOptions(queryExecutor);
-        // Skip vertx-sql-client instrumentation for JDBC-backed connections
-        // (connect options are not available for the JDBC path) —
-        // let JDBC instrumentation handle them instead
-        if (connectOptions == null) {
-          return new AdviceScope(callDepth);
-        }
         // Try db system stored from pool class first (handles generic SqlConnectOptions),
         // fall back to class name detection on the connect options itself
         String dbSystem = VertxSqlClientSingletons.getConnectOptionsDbSystem(connectOptions);

instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/QueryExecutorInstrumentation.java

@@ -43,7 +43,6 @@ public List<String> injectedClassNames() {
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
     return asList(
-        new CommandSchedulerInstrumentation(),
         new PoolInstrumentation(),
         new SqlClientBaseInstrumentation(),
         new QueryExecutorInstrumentation(),

instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxSqlClientInstrumentationModule.java

@@ -103,12 +103,6 @@ public static AdviceScope start(Object queryExecutor, Object[] arguments) {
         }
 
         SqlConnectOptions connectOptions = QueryExecutorUtil.getConnectOptions(queryExecutor);
-        // Skip vertx-sql-client instrumentation for JDBC-backed connections
-        // (connect options are not available for the JDBC path) —
-        // let JDBC instrumentation handle them instead
-        if (connectOptions == null) {
-          return new AdviceScope(callDepth);
-        }
         String dbSystem = VertxSqlClientSingletons.getConnectOptionsDbSystem(connectOptions);
         VertxSqlClientRequest otelRequest =
             new VertxSqlClientRequest(sql, connectOptions, preparedStatement, dbSystem);

instrumentation/vertx/vertx-sql-client/vertx-sql-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/sql/VertxJdbcClientTest.java

@@ -43,7 +43,6 @@ public List<String> injectedClassNames() {
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
     return asList(
-        new CommandSchedulerInstrumentation(),
         new DriverInstrumentation(),
         new PoolInstrumentation(),
         new SqlClientBaseInstrumentation(),