rename

Author: zeitlinger

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesGetter.java

@@ -55,13 +55,13 @@ default String getRpcMethod(REQUEST request) {
   }
 
   /**
-   * Returns whether the RPC method is a well-known method.
+   * Returns whether the RPC method is a predefined method at the start of the RPC framework.
    *
    * <p>This is used to determine whether to set the {@code rpc.method} attribute to the actual
    * method name, or to set it to {@code "_OTHER"} and store the actual method name in {@code
    * rpc.method_original}.
    */
-  default boolean isWellKnownMethod(REQUEST request) {
+  default boolean isPredefined(REQUEST request) {
     return false;
   }
 }

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcCommonAttributesExtractor.java

@@ -49,7 +49,7 @@ public final void onStart(AttributesBuilder attributes, Context parentContext, R
           RPC_SYSTEM_NAME,
           system == null ? null : SemconvStability.stableRpcSystemName(system));
       String method = getter.getRpcMethod(request);
-      if (getter.isWellKnownMethod(request)) {
+      if (getter.isPredefined(request)) {
         internalSet(attributes, RPC_METHOD, method);
       } else {
         internalSet(attributes, RPC_METHOD_ORIGINAL, method);

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcAttributesExtractorTest.java

@@ -26,10 +26,10 @@ class RpcAttributesExtractorTest {
 
   private static class TestGetter implements RpcAttributesGetter<Map<String, String>> {
 
-    private final boolean wellKnownMethod;
+    private final boolean predefined;
 
-    private TestGetter(boolean wellKnownMethod) {
-      this.wellKnownMethod = wellKnownMethod;
+    private TestGetter(boolean predefined) {
+      this.predefined = predefined;
     }
 
     @Override
@@ -60,8 +60,8 @@ public String getRpcMethod(Map<String, String> request) {
     }
 
     @Override
-    public boolean isWellKnownMethod(Map<String, String> stringStringMap) {
-      return wellKnownMethod;
+    public boolean isPredefined(Map<String, String> stringStringMap) {
+      return predefined;
     }
   }
 
@@ -71,7 +71,7 @@ void server() {
   }
 
   @Test
-  void serverWellKnown() {
+  void serverPredefined() {
     testExtractor(RpcServerAttributesExtractor.create(new TestGetter(true)), null);
   }
 
@@ -81,7 +81,7 @@ void client() {
   }
 
   @Test
-  void clientWellKnown() {
+  void clientPredefined() {
     testExtractor(RpcClientAttributesExtractor.create(new TestGetter(true)), null);
   }