Code review sweep (run 25199276408) (#18475)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>

Author: otelbot[bot]

.github/agents/knowledge/testing-general-patterns.md

@@ -83,6 +83,11 @@
   `hasAttributesSatisfyingExactly(...)` in the same assertion chain, because the exact
   variant already validates the total attribute count. Remove the `hasTotalAttributeCount`
   call.
+- These rules apply to **span** attribute assertions only. Metric point assertions are
+  different: metric point assertions do not have a `hasTotalAttributeCount(...)` method, so
+  the span guidance about preferring `hasTotalAttributeCount(0)` for zero-attribute checks
+  does not apply. For metric points, used `point.hasAttributes(Attributes.empty())` — it
+  reads more clearly than the no-arg `hasAttributesSatisfyingExactly()` form.
 - For non-semconv attribute keys in `equalTo(...)`, use inline `AttributeKey` factory
   methods — `longKey("name")`, `stringKey("name")`, etc. — directly in the assertion.
   Do **not** extract them into class-level `private static final AttributeKey<T>` constants.

instrumentation/logback/logback-mdc-1.0/library/src/addBaggageTest/java/io/opentelemetry/instrumentation/logback/mdc/v1_0/LogbackWithBaggageTest.java

@@ -12,7 +12,7 @@
 class LogbackWithBaggageTest extends AbstractLogbackTest {
 
   @RegisterExtension
-  static InstrumentationExtension testing = LibraryInstrumentationExtension.create();
+  static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
 
   @Override
   protected InstrumentationExtension getInstrumentationExtension() {

instrumentation/logback/logback-mdc-1.0/library/src/loggingKeysTest/java/io/opentelemetry/instrumentation/logback/mdc/v1_0/LogbackWithLoggingKeysTest.java

@@ -12,7 +12,7 @@
 class LogbackWithLoggingKeysTest extends AbstractLogbackTest {
 
   @RegisterExtension
-  static InstrumentationExtension testing = LibraryInstrumentationExtension.create();
+  static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
 
   @Override
   protected InstrumentationExtension getInstrumentationExtension() {

instrumentation/logback/logback-mdc-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/mdc/v1_0/OpenTelemetryAppender.java

@@ -21,10 +21,11 @@
 import java.util.HashMap;
 import java.util.Iterator;
 import java.util.Map;
+import javax.annotation.Nullable;
 
 public class OpenTelemetryAppender extends UnsynchronizedAppenderBase<ILoggingEvent>
     implements AppenderAttachable<ILoggingEvent> {
-  private static final Field MDC_MAP_FIELD;
+  @Nullable private static final Field MDC_MAP_FIELD;
 
   static {
     Field field;

instrumentation/logback/logback-mdc-1.0/library/src/test/java/io/opentelemetry/instrumentation/logback/mdc/v1_0/LogbackTest.java

@@ -16,7 +16,7 @@
 class LogbackTest extends AbstractLogbackTest {
 
   @RegisterExtension
-  static InstrumentationExtension testing = LibraryInstrumentationExtension.create();
+  static final InstrumentationExtension testing = LibraryInstrumentationExtension.create();
 
   @Override
   protected InstrumentationExtension getInstrumentationExtension() {

instrumentation/micrometer/micrometer-1.5/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/micrometer/v1_5/TimeUnitParser.java

@@ -14,15 +14,14 @@
 import static java.util.concurrent.TimeUnit.SECONDS;
 import static java.util.logging.Level.WARNING;
 
-import io.opentelemetry.instrumentation.micrometer.v1_5.OpenTelemetryMeterRegistry;
 import java.util.Locale;
 import java.util.concurrent.TimeUnit;
 import java.util.logging.Logger;
 import javax.annotation.Nullable;
 
 final class TimeUnitParser {
 
-  private static final Logger logger = Logger.getLogger(OpenTelemetryMeterRegistry.class.getName());
+  private static final Logger logger = Logger.getLogger(TimeUnitParser.class.getName());
 
   static TimeUnit parseConfigValue(@Nullable String value) {
     if (value == null) {

instrumentation/mongo/mongo-4.0/javaagent/build.gradle.kts

@@ -22,7 +22,6 @@ dependencies {
   testLibrary("org.mongodb:mongodb-driver-reactivestreams:4.0.0")
 
   testImplementation(project(":instrumentation:mongo:mongo-common:testing"))
-  testImplementation("de.flapdoodle.embed:de.flapdoodle.embed.mongo:1.50.5")
 
   testInstrumentation(project(":instrumentation:mongo:mongo-async-3.3:javaagent"))
   testInstrumentation(project(":instrumentation:mongo:mongo-3.1:javaagent"))