Skip to content

Commit 41c75ed

Browse files
committed
Revert GwtSingletons visibility to public to fix IllegalAccessError
ByteBuddy advice with inline=false in GwtRpcInstrumentation references GwtSingletons from instrumented class com.google.gwt.user.server.rpc.RPC, which is in a different package. Making the class and its members package-private caused IllegalAccessError at runtime, breaking GwtTest.
1 parent 1d535da commit 41c75ed

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

  • instrumentation/gwt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/v2_0

instrumentation/gwt-2.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/gwt/v2_0/GwtSingletons.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@
1313
import io.opentelemetry.instrumentation.api.instrumenter.SpanKindExtractor;
1414
import java.lang.reflect.Method;
1515

16-
class GwtSingletons {
16+
public class GwtSingletons {
1717

1818
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.gwt-2.0";
1919

20-
static final ContextKey<Boolean> RPC_CONTEXT_KEY =
20+
public static final ContextKey<Boolean> RPC_CONTEXT_KEY =
2121
ContextKey.named("opentelemetry-gwt-rpc-context-key");
2222

2323
private static final Instrumenter<Method, Void> instrumenter;
@@ -33,7 +33,7 @@ class GwtSingletons {
3333
.buildInstrumenter(SpanKindExtractor.alwaysServer());
3434
}
3535

36-
static Instrumenter<Method, Void> instrumenter() {
36+
public static Instrumenter<Method, Void> instrumenter() {
3737
return instrumenter;
3838
}
3939

0 commit comments

Comments
 (0)