Skip to content

Commit 4c72e3d

Browse files
authored
Review fixes for restlet-2.0:library (#17015)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 9f8c22f commit 4c72e3d

4 files changed

Lines changed: 7 additions & 7 deletions

File tree

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/TracingFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ final class TracingFilter extends Filter {
2121
private final Instrumenter<Request, Response> instrumenter;
2222
private final String path;
2323

24-
public TracingFilter(Instrumenter<Request, Response> instrumenter, String path) {
24+
TracingFilter(Instrumenter<Request, Response> instrumenter, String path) {
2525
this.instrumenter = instrumenter;
2626
this.path = path;
2727
}

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/internal/RestletHeadersGetter.java

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,21 +53,22 @@ public Iterable<String> keys(Request carrier) {
5353
}
5454

5555
@Override
56-
public String get(Request carrier, String key) {
56+
@Nullable
57+
public String get(@Nullable Request carrier, String key) {
5758
Series<?> headers = getHeaders(carrier);
5859
return headers == null ? null : headers.getFirstValue(key, /* ignoreCase= */ true);
5960
}
6061

6162
@Override
62-
public Iterator<String> getAll(Request carrier, String key) {
63+
public Iterator<String> getAll(@Nullable Request carrier, String key) {
6364
Series<?> headers = getHeaders(carrier);
6465
return headers == null
6566
? emptyIterator()
6667
: asList(headers.getValuesArray(key, /* ignoreCase= */ true)).iterator();
6768
}
6869

6970
@Nullable
70-
static Series<?> getHeaders(Message carrier) {
71+
static Series<?> getHeaders(@Nullable Message carrier) {
7172
if (GET_ATTRIBUTES == null) {
7273
return null;
7374
}

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/internal/RestletHttpAttributesGetter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@
1616
import org.restlet.Response;
1717
import org.restlet.util.Series;
1818

19-
enum RestletHttpAttributesGetter implements HttpServerAttributesGetter<Request, Response> {
20-
INSTANCE;
19+
final class RestletHttpAttributesGetter implements HttpServerAttributesGetter<Request, Response> {
2120

2221
@Override
2322
public String getHttpRequestMethod(Request request) {

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/internal/RestletTelemetryBuilderFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public static DefaultHttpServerInstrumenterBuilder<Request, Response> create(
2222
return DefaultHttpServerInstrumenterBuilder.create(
2323
"io.opentelemetry.restlet-2.0",
2424
openTelemetry,
25-
RestletHttpAttributesGetter.INSTANCE,
25+
new RestletHttpAttributesGetter(),
2626
new RestletHeadersGetter());
2727
}
2828
}

0 commit comments

Comments
 (0)