Skip to content

Commit 577c288

Browse files
committed
Fix unknownService test for old semconv mode
- Remove rpc.method and rpc.method_original assertions from _OTHER server span (old semconv getMethod() returns null when fullMethodName has no slash)
1 parent 89ef4f4 commit 577c288

1 file changed

Lines changed: 0 additions & 3 deletions

File tree

  • instrumentation/grpc-1.6/testing/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6

instrumentation/grpc-1.6/testing/src/main/java/io/opentelemetry/instrumentation/grpc/v1_6/AbstractGrpcTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import static io.opentelemetry.semconv.incubating.MessageIncubatingAttributes.MESSAGE_TYPE;
2121
import static io.opentelemetry.semconv.incubating.RpcIncubatingAttributes.RPC_GRPC_STATUS_CODE;
2222
import static io.opentelemetry.semconv.incubating.RpcIncubatingAttributes.RPC_METHOD;
23-
import static io.opentelemetry.semconv.incubating.RpcIncubatingAttributes.RPC_METHOD_ORIGINAL;
2423
import static io.opentelemetry.semconv.incubating.RpcIncubatingAttributes.RPC_SERVICE;
2524
import static io.opentelemetry.semconv.incubating.RpcIncubatingAttributes.RPC_SYSTEM;
2625
import static java.util.Collections.singletonList;
@@ -717,8 +716,6 @@ void unknownService() throws Exception {
717716
.hasStatus(StatusData.error())
718717
.hasAttributesSatisfyingExactly(
719718
equalTo(RPC_SYSTEM, "grpc"),
720-
equalTo(RPC_METHOD, "_OTHER"),
721-
equalTo(RPC_METHOD_ORIGINAL, "example.Greeter/SayHello"),
722719
equalTo(
723720
RPC_GRPC_STATUS_CODE,
724721
(long) Status.Code.UNIMPLEMENTED.value()))));

0 commit comments

Comments
 (0)