Skip to content

Commit 5a05921

Browse files
authored
Review fixes for jetty-common:javaagent (#17457)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent ed83e41 commit 5a05921

File tree

1 file changed

+3
-1
lines changed
  • instrumentation/jetty/jetty-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/common

1 file changed

+3
-1
lines changed

instrumentation/jetty/jetty-common/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jetty/common/JettyHelper.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
import io.opentelemetry.instrumentation.servlet.internal.ServletRequestContext;
1313
import io.opentelemetry.instrumentation.servlet.internal.ServletResponseContext;
1414
import io.opentelemetry.javaagent.instrumentation.servlet.ServletHelper;
15+
import javax.annotation.Nullable;
1516

1617
public class JettyHelper<REQUEST, RESPONSE> extends ServletHelper<REQUEST, RESPONSE> {
1718

@@ -25,7 +26,7 @@ public void end(
2526
ServletRequestContext<REQUEST> requestContext,
2627
REQUEST request,
2728
RESPONSE response,
28-
Throwable throwable,
29+
@Nullable Throwable throwable,
2930
Context context,
3031
Scope scope) {
3132

@@ -43,6 +44,7 @@ public void end(
4344
}
4445
}
4546

47+
@Nullable
4648
private Throwable errorException(REQUEST request) {
4749
Object value = accessor.getRequestAttribute(request, errorExceptionAttributeName());
4850

0 commit comments

Comments
 (0)