Skip to content

Commit 5b82e61

Browse files
committed
simplify
1 parent 2352c20 commit 5b82e61

2 files changed

Lines changed: 6 additions & 20 deletions

File tree

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcClientMetricsTest.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import io.opentelemetry.api.trace.TraceState;
2727
import io.opentelemetry.context.Context;
2828
import io.opentelemetry.instrumentation.api.instrumenter.OperationListener;
29-
import io.opentelemetry.instrumentation.api.internal.SemconvStability;
3029
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
3130
import io.opentelemetry.sdk.metrics.data.MetricData;
3231
import io.opentelemetry.sdk.testing.exporter.InMemoryMetricReader;
@@ -51,9 +50,7 @@ void collectsMetrics() {
5150
.put(
5251
RPC_METHOD,
5352
emitStableRpcSemconv() ? "myservice.EchoService/exampleMethod" : "exampleMethod")
54-
.put(
55-
RPC_SYSTEM_NAME,
56-
emitStableRpcSemconv() ? SemconvStability.stableRpcSystemName("grpc") : null)
53+
.put(RPC_SYSTEM_NAME, emitStableRpcSemconv() ? "grpc" : null)
5754
.build();
5855

5956
Attributes requestAttributes1 =
@@ -197,9 +194,7 @@ void collectsMetrics() {
197194
equalTo(
198195
RPC_METHOD,
199196
"myservice.EchoService/exampleMethod"),
200-
equalTo(
201-
RPC_SYSTEM_NAME,
202-
SemconvStability.stableRpcSystemName("grpc")),
197+
equalTo(RPC_SYSTEM_NAME, "grpc"),
203198
equalTo(SERVER_ADDRESS, "example.com"),
204199
equalTo(SERVER_PORT, 8080))
205200
.hasExemplarsSatisfying(
@@ -253,9 +248,7 @@ void collectsMetrics() {
253248
equalTo(
254249
RPC_METHOD,
255250
"myservice.EchoService/exampleMethod"),
256-
equalTo(
257-
RPC_SYSTEM_NAME,
258-
SemconvStability.stableRpcSystemName("grpc")),
251+
equalTo(RPC_SYSTEM_NAME, "grpc"),
259252
equalTo(SERVER_PORT, 8080)))));
260253
}
261254
}

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/rpc/RpcServerMetricsTest.java

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@
2727
import io.opentelemetry.api.trace.TraceState;
2828
import io.opentelemetry.context.Context;
2929
import io.opentelemetry.instrumentation.api.instrumenter.OperationListener;
30-
import io.opentelemetry.instrumentation.api.internal.SemconvStability;
3130
import io.opentelemetry.sdk.metrics.SdkMeterProvider;
3231
import io.opentelemetry.sdk.metrics.data.MetricData;
3332
import io.opentelemetry.sdk.testing.exporter.InMemoryMetricReader;
@@ -52,9 +51,7 @@ void collectsMetrics() {
5251
.put(
5352
RPC_METHOD,
5453
emitStableRpcSemconv() ? "myservice.EchoService/exampleMethod" : "exampleMethod")
55-
.put(
56-
RPC_SYSTEM_NAME,
57-
emitStableRpcSemconv() ? SemconvStability.stableRpcSystemName("grpc") : null)
54+
.put(RPC_SYSTEM_NAME, emitStableRpcSemconv() ? "grpc" : null)
5855
.build();
5956

6057
Attributes requestAttributes1 =
@@ -203,9 +200,7 @@ void collectsMetrics() {
203200
equalTo(
204201
RPC_METHOD,
205202
"myservice.EchoService/exampleMethod"),
206-
equalTo(
207-
RPC_SYSTEM_NAME,
208-
SemconvStability.stableRpcSystemName("grpc")),
203+
equalTo(RPC_SYSTEM_NAME, "grpc"),
209204
equalTo(SERVER_ADDRESS, "example.com"),
210205
equalTo(SERVER_PORT, 8080))
211206
.hasExemplarsSatisfying(
@@ -259,9 +254,7 @@ void collectsMetrics() {
259254
equalTo(
260255
RPC_METHOD,
261256
"myservice.EchoService/exampleMethod"),
262-
equalTo(
263-
RPC_SYSTEM_NAME,
264-
SemconvStability.stableRpcSystemName("grpc")),
257+
equalTo(RPC_SYSTEM_NAME, "grpc"),
265258
equalTo(SERVER_PORT, 8080)))));
266259
}
267260
}

0 commit comments

Comments
 (0)