Skip to content

Commit 600bb79

Browse files
authored
Review fixes for jetty-httpclient-12.0:testing (#18084)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent 6b718f4 commit 600bb79

File tree

1 file changed

+2
-2
lines changed
  • instrumentation/jetty-httpclient/jetty-httpclient-12.0/testing/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v12_0

1 file changed

+2
-2
lines changed

instrumentation/jetty-httpclient/jetty-httpclient-12.0/testing/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v12_0/AbstractJettyClient12Test.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,15 +115,15 @@ public void sendRequestWithCallback(
115115
}
116116

117117
@Test
118-
void callbacksCalled() throws InterruptedException, ExecutionException {
118+
void callbacksCalled() {
119119
URI uri = resolveAddress("/success");
120120
Request request = client.newRequest(uri).method("GET");
121121

122122
CompletableFuture<Response> responseFuture = new CompletableFuture<>();
123123
TracingResponseListener responseListener = new TracingResponseListener(responseFuture);
124124

125125
testing.runWithSpan("parent", () -> request.send(responseListener));
126-
Response response = responseFuture.get();
126+
Response response = responseFuture.join();
127127

128128
assertThat(response.getStatus()).isEqualTo(200);
129129
testing.waitAndAssertTraces(

0 commit comments

Comments
 (0)