Skip to content

Commit 611e2e5

Browse files
trasktrask
authored
Add prettier to spotless (#18952)
1 parent 5876300 commit 611e2e5

65 files changed

Lines changed: 683 additions & 671 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/agents/knowledge/README.md‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,21 @@ Load only files relevant to the current scope to reduce noise and avoid over-con
66

77
## Topics
88

9-
| File | Load when |
10-
| --- | --- |
11-
| `api-deprecation-policy.md` | Public API removal, rename, or deprecation; stable vs alpha breaking changes |
12-
| `config-property-stability.md` | `otel.instrumentation.*` property add, remove, rename, or deprecation |
13-
| `general-rules.md` | Always — review checklist table and core rules enforced on every review |
14-
| `metadata-yaml-format.md` | Always — mandatory review of metadata.yaml for config coverage |
15-
| `gradle-conventions.md` | `build.gradle.kts` or `settings.gradle.kts` changes, custom test task registration or wiring |
16-
| `javaagent-advice-patterns.md` | ByteBuddy `@Advice` class or advice-method changes |
17-
| `javaagent-module-patterns.md` | `InstrumentationModule`, `TypeInstrumentation`, `VirtualField`, `CallDepth` |
18-
| `javaagent-singletons-patterns.md` | `*Singletons`, `*SpanNaming`, and similar holder classes; singleton accessors; callers of singleton accessors/fields |
19-
| `library-patterns.md` | Library instrumentation telemetry, builder, getter, or setter pattern changes |
20-
| `module-naming.md` | New or renamed modules or packages; settings includes |
21-
| `testing-general-patterns.md` | Test files in scope — assertion style, test method signatures and throws clauses, resource cleanup patterns, abstract test base class state shape, attribute assertion patterns, `satisfies()` lambda usage |
22-
| `testing-experimental-flags.md` | `testExperimental` task or experimental span-attribute assertions |
23-
| `testing-semconv-stability.md` | Semconv opt-in modes, `emitOld*`/`emitStable*`, `maybeStable`, Semconv test tasks |
9+
| File | Load when |
10+
| ---------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
11+
| `api-deprecation-policy.md` | Public API removal, rename, or deprecation; stable vs alpha breaking changes |
12+
| `config-property-stability.md` | `otel.instrumentation.*` property add, remove, rename, or deprecation |
13+
| `general-rules.md` | Always — review checklist table and core rules enforced on every review |
14+
| `metadata-yaml-format.md` | Always — mandatory review of metadata.yaml for config coverage |
15+
| `gradle-conventions.md` | `build.gradle.kts` or `settings.gradle.kts` changes, custom test task registration or wiring |
16+
| `javaagent-advice-patterns.md` | ByteBuddy `@Advice` class or advice-method changes |
17+
| `javaagent-module-patterns.md` | `InstrumentationModule`, `TypeInstrumentation`, `VirtualField`, `CallDepth` |
18+
| `javaagent-singletons-patterns.md` | `*Singletons`, `*SpanNaming`, and similar holder classes; singleton accessors; callers of singleton accessors/fields |
19+
| `library-patterns.md` | Library instrumentation telemetry, builder, getter, or setter pattern changes |
20+
| `module-naming.md` | New or renamed modules or packages; settings includes |
21+
| `testing-general-patterns.md` | Test files in scope — assertion style, test method signatures and throws clauses, resource cleanup patterns, abstract test base class state shape, attribute assertion patterns, `satisfies()` lambda usage |
22+
| `testing-experimental-flags.md` | `testExperimental` task or experimental span-attribute assertions |
23+
| `testing-semconv-stability.md` | Semconv opt-in modes, `emitOld*`/`emitStable*`, `maybeStable`, Semconv test tasks |
2424

2525
## Naming Conventions
2626

‎.github/agents/knowledge/config-property-stability.md‎

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ declarative API.
3030

3131
### Two User-Facing Surfaces
3232

33-
| Surface | Experimental marker | Stable marker |
34-
| --- | --- | --- |
33+
| Surface | Experimental marker | Stable marker |
34+
| ------------- | ------------------------------- | ----------------------------- |
3535
| Flat property | word `experimental` in the name | no `experimental` in the name |
36-
| YAML key | `/development` suffix | no suffix |
36+
| YAML key | `/development` suffix | no suffix |
3737

3838
The bridge translates between them (underscores ↔ hyphens, `/development` ↔ `experimental.`
3939
prefix, `SPECIAL_MAPPINGS` for legacy renames that don't follow the mechanical rule).
@@ -42,10 +42,10 @@ prefix, `SPECIAL_MAPPINGS` for legacy renames that don't follow the mechanical r
4242

4343
Defined in [VERSIONING.md](../../../VERSIONING.md):
4444

45-
| Tier | Flat property pattern | YAML key pattern | Breaking changes allowed? |
46-
| --- | --- | --- | --- |
47-
| **Stable** | No `experimental` in name, not under `otel.javaagent.testing.*` | No `/development` suffix | ❌ Deprecate in minor, **remove only in 3.0** |
48-
| **Experimental** | Contains `experimental` anywhere | Has `/development` suffix | ✅ Deprecate in one release, remove in next |
45+
| Tier | Flat property pattern | YAML key pattern | Breaking changes allowed? |
46+
| ---------------- | --------------------------------------------------------------- | ------------------------- | --------------------------------------------- |
47+
| **Stable** | No `experimental` in name, not under `otel.javaagent.testing.*` | No `/development` suffix | ❌ Deprecate in minor, **remove only in 3.0** |
48+
| **Experimental** | Contains `experimental` anywhere | Has `/development` suffix | ✅ Deprecate in one release, remove in next |
4949

5050
`otel.javaagent.testing.*` — always allowed to break, regardless of marker.
5151

@@ -92,13 +92,13 @@ if (value == null) {
9292

9393
## Naming Conventions
9494

95-
| Rule | Flat property | YAML key |
96-
| --- | --- | --- |
97-
| Prefix | `otel.instrumentation.<module>.` or `otel.instrumentation.common.` | Under `instrumentation/development → java → <module>` or `common` |
98-
| Word separator | hyphens (kebab-case) | underscores (snake_case) |
99-
| Experimental marker | `experimental` in name | `/development` suffix |
100-
| Boolean toggle | `.enabled` suffix | `enabled` leaf key |
101-
| Env var form | dots/hyphens → ALL_CAPS underscores | N/A |
95+
| Rule | Flat property | YAML key |
96+
| ------------------- | ------------------------------------------------------------------ | ----------------------------------------------------------------- |
97+
| Prefix | `otel.instrumentation.<module>.` or `otel.instrumentation.common.` | Under `instrumentation/development → java → <module>` or `common` |
98+
| Word separator | hyphens (kebab-case) | underscores (snake_case) |
99+
| Experimental marker | `experimental` in name | `/development` suffix |
100+
| Boolean toggle | `.enabled` suffix | `enabled` leaf key |
101+
| Env var form | dots/hyphens → ALL_CAPS underscores | N/A |
102102

103103
## Structured Config (YAML-Only)
104104

0 commit comments

Comments
 (0)