Review fixes for jaxws-metro-2.2:javaagent (#18150)

Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: trask <218610+trask@users.noreply.github.com>

Author: 3 people

instrumentation/jaxws/jaxws-metro-2.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/metro/MetroServerSpanNameUpdater.java

@@ -17,6 +17,7 @@
 import java.util.LinkedHashMap;
 import java.util.Map;
 import java.util.logging.Logger;
+import javax.annotation.Nullable;
 import javax.xml.namespace.QName;
 
 final class MetroServerSpanNameUpdater {
@@ -73,9 +74,6 @@ private void registerHttpServletRequestAdapter(
 
   public void updateServerSpanName(Context context, MetroRequest metroRequest) {
     String spanName = metroRequest.spanName();
-    if (spanName == null) {
-      return;
-    }
 
     Span serverSpan = LocalRootSpan.fromContextOrNull(context);
     if (serverSpan == null) {
@@ -141,14 +139,17 @@ boolean canHandle(Object httpServletRequest) {
       return httpServletRequestClass.isInstance(httpServletRequest);
     }
 
+    @Nullable
     String getServletPath(Object httpServletRequest) {
       return invokeSafely(getServletPathMethodHandle, httpServletRequest);
     }
 
+    @Nullable
     String getPathInfo(Object httpServletRequest) {
       return invokeSafely(getPathInfoMethodHandle, httpServletRequest);
     }
 
+    @Nullable
     private static String invokeSafely(MethodHandle methodHandle, Object httpServletRequest) {
       try {
         return (String) methodHandle.invoke(httpServletRequest);

instrumentation/jaxws/jaxws-metro-2.2/metadata.yaml

@@ -8,6 +8,7 @@ features:
   - CONTROLLER_SPANS
 configurations:
   - name: otel.instrumentation.common.experimental.controller-telemetry.enabled
+    declarative_name: java.common.controller_telemetry/development.enabled
     description: Enables the creation of experimental controller spans.
     type: boolean
     default: false