Skip to content

Commit 6809907

Browse files
committed
Review fixes for azure-core-1.53:javaagent
Automated code review of instrumentation/azure-core/azure-core-1.53/javaagent.
1 parent fb8f41e commit 6809907

1 file changed

Lines changed: 10 additions & 1 deletion

File tree

  • instrumentation/azure-core/azure-core-1.53/javaagent/src/testAzure/java/io/opentelemetry/javaagent/instrumentation/azurecore/v1_53

instrumentation/azure-core/azure-core-1.53/javaagent/src/testAzure/java/io/opentelemetry/javaagent/instrumentation/azurecore/v1_53/AzureSdkTest.java

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,11 @@
77

88
import static io.opentelemetry.api.common.AttributeKey.stringKey;
99
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
10+
import static io.opentelemetry.semconv.HttpAttributes.HTTP_REQUEST_METHOD;
1011
import static io.opentelemetry.semconv.HttpAttributes.HTTP_RESPONSE_STATUS_CODE;
12+
import static io.opentelemetry.semconv.ServerAttributes.SERVER_ADDRESS;
13+
import static io.opentelemetry.semconv.ServerAttributes.SERVER_PORT;
14+
import static io.opentelemetry.semconv.UrlAttributes.URL_FULL;
1115
import static org.assertj.core.api.Assertions.assertThat;
1216

1317
import com.azure.core.annotation.ExpectedResponses;
@@ -105,7 +109,12 @@ void testPipelineAndSuppression() {
105109
span.hasKind(SpanKind.CLIENT)
106110
.hasName("GET")
107111
.hasStatus(StatusData.unset())
108-
.hasAttribute(HTTP_RESPONSE_STATUS_CODE, 200L)));
112+
.hasAttributesSatisfyingExactly(
113+
equalTo(HTTP_REQUEST_METHOD, "GET"),
114+
equalTo(HTTP_RESPONSE_STATUS_CODE, 200L),
115+
equalTo(SERVER_ADDRESS, "azure.com"),
116+
equalTo(SERVER_PORT, 443),
117+
equalTo(URL_FULL, "https://azure.com/path"))));
109118
}
110119

111120
@Test

0 commit comments

Comments
 (0)