Commit 6a1838d
committed
Revert HelidonServerResponseMutator singleton; instantiate inline
Matches the dominant convention for non-enum HttpServerResponseMutator implementations in this repo (Akka, Pekko, Grizzly, Jetty 8/11/12, Servlet 3/5, Liberty all use 'new XyzResponseMutator()' at the call site) and the default rule in general-rules.md ('Prefer Instance Creation Over Singletons'). Header customization is not a hot path that warrants the singleton exception.1 parent c1d849f commit 6a1838d
2 files changed
Lines changed: 1 addition & 5 deletions
File tree
- instrumentation/helidon-4.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/helidon/v4_3
Lines changed: 0 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
14 | | - | |
15 | | - | |
16 | | - | |
17 | 13 | | |
18 | 14 | | |
19 | 15 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
| 24 | + | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
0 commit comments