Skip to content

Commit 70489f1

Browse files
committed
Review fixes for hibernate-4.0:javaagent
Automated code review of instrumentation/hibernate/hibernate-4.0/javaagent.
1 parent b227bab commit 70489f1

3 files changed

Lines changed: 7 additions & 7 deletions

File tree

instrumentation/hibernate/hibernate-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/EntityNameUtil.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,9 @@
1212

1313
public class EntityNameUtil {
1414

15-
private EntityNameUtil() {}
15+
public static Function<Object, String> bestGuessEntityName(SharedSessionContract session) {
16+
return entity -> bestGuessEntityName(session, entity);
17+
}
1618

1719
private static String bestGuessEntityName(SharedSessionContract session, Object entity) {
1820
if (entity == null) {
@@ -28,7 +30,5 @@ private static String bestGuessEntityName(SharedSessionContract session, Object
2830
return null;
2931
}
3032

31-
public static Function<Object, String> bestGuessEntityName(SharedSessionContract session) {
32-
return (entity) -> bestGuessEntityName(session, entity);
33-
}
33+
private EntityNameUtil() {}
3434
}

instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/hibernate/v4_0/EntityManagerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050

5151
class EntityManagerTest extends AbstractHibernateTest {
5252

53-
static final EntityManagerFactory entityManagerFactory =
53+
private static final EntityManagerFactory entityManagerFactory =
5454
Persistence.createEntityManagerFactory("test-pu");
5555

5656
@AfterAll

instrumentation/hibernate/hibernate-4.0/javaagent/src/test/java/spring/jpa/SpringJpaTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,9 @@ class SpringJpaTest {
3939
@RegisterExtension
4040
protected static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
4141

42-
AnnotationConfigApplicationContext context =
42+
private final AnnotationConfigApplicationContext context =
4343
new AnnotationConfigApplicationContext(PersistenceConfig.class);
44-
CustomerRepository repo = context.getBean(CustomerRepository.class);
44+
private final CustomerRepository repo = context.getBean(CustomerRepository.class);
4545

4646
@AfterEach
4747
void closeContext() {

0 commit comments

Comments
 (0)