chore: tidy up from PR review

Author: dmarkwat

instrumentation/finagle-http-23.11/compile-stub/src/main/java/com/twitter/util/Promise.java

@@ -6,7 +6,8 @@
 package com.twitter.util;
 
 // public accessible stubs of mirrored types in com.twitter.util to ensure compilation;
-// these must be stripped out at jar construction -- see build.gradle.kts
+// these classes are consumed as a compileOnly module and replaced at runtime with their
+// stubbed counterparts
 public class Promise {
   private Promise() {}
 

instrumentation/finagle-http-23.11/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/finaglehttp/v23_11/ChannelTransportInstrumentation.java

@@ -24,8 +24,7 @@ public ElementMatcher<TypeDescription> typeMatcher() {
 
   @Override
   public void transform(TypeTransformer transformer) {
-    transformer.applyAdviceToMethod(
-        isConstructor(), ChannelTransportInstrumentation.class.getName() + "$ConstructorAdvice");
+    transformer.applyAdviceToMethod(isConstructor(), getClass().getName() + "$ConstructorAdvice");
   }
 
   @SuppressWarnings("unused")

instrumentation/finagle-http-23.11/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/finaglehttp/v23_11/PromiseInterruptibleInstrumentation.java

@@ -44,8 +44,7 @@ public static PartialFunction<Throwable, BoxedUnit> onExit(
       if (handler instanceof TwitterUtilCoreHelpers.InterruptibleWithContext) {
         return handler;
       }
-      Context context = Context.current();
-      return new TwitterUtilCoreHelpers.InterruptibleWithContext(context, handler);
+      return new TwitterUtilCoreHelpers.InterruptibleWithContext(Context.current(), handler);
     }
   }
 }

instrumentation/finagle-http-23.11/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/finaglehttp/v23_11/PromiseKInstrumentation.java

@@ -51,8 +51,7 @@ public static void onExit(
         @Advice.This
             @SuppressWarnings("rawtypes") // type is from compile-stub and masks private type
             Promise.K thiz) {
-      Context current = Context.current();
-      TwitterUtilCoreHelpers.PROMISE_K_CONTEXT_FIELD.set(thiz, current);
+      TwitterUtilCoreHelpers.PROMISE_K_CONTEXT_FIELD.set(thiz, Context.current());
     }
   }