Address review comment: deduplicate common config warnings

Author: trask

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/config/internal/CommonConfig.java

@@ -13,6 +13,7 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
 import java.util.logging.Logger;
 
 /**
@@ -21,6 +22,7 @@
  */
 public final class CommonConfig {
   private static final Logger logger = Logger.getLogger(CommonConfig.class.getName());
+  private static final Set<String> warnedDeprecatedProperties = ConcurrentHashMap.newKeySet();
 
   private final List<String> clientRequestHeaders;
   private final List<String> clientResponseHeaders;
@@ -131,13 +133,15 @@ private static String getConfig(
     }
     value = config.getString(oldDeclarativeKey);
     if (value != null) {
-      logger.warning(
-          "The "
-              + oldProperty
-              + " setting and the equivalent declarative configuration property"
-              + " are deprecated and will be removed in 3.0. Use "
-              + newProperty
-              + " or equivalent declarative configuration instead.");
+      if (warnedDeprecatedProperties.add(oldProperty)) {
+        logger.warning(
+            "The "
+                + oldProperty
+                + " setting and the equivalent declarative configuration property"
+                + " are deprecated and will be removed in 3.0. Use "
+                + newProperty
+                + " or equivalent declarative configuration instead.");
+      }
       return value;
     }
     return defaultValue;

instrumentation/log4j/log4j-appender-2.17/library/src/main/java/io/opentelemetry/instrumentation/log4j/appender/v2_17/OpenTelemetryAppender.java

@@ -334,7 +334,7 @@ private void emit(OpenTelemetry openTelemetry, LogEvent event) {
       String traceId = contextDataAccessor.getValue(contextData, contextDataKeys.getTraceIdKey());
       String spanId = contextDataAccessor.getValue(contextData, contextDataKeys.getSpanIdKey());
       String traceFlags =
-          contextDataAccessor.getValue(contextData, contextDataKeys.getTraceFlags());
+          contextDataAccessor.getValue(contextData, contextDataKeys.getTraceFlagsKey());
       if (traceId != null && spanId != null && traceFlags != null) {
         context =
             Context.root()