Skip to content

Commit 787e9fc

Browse files
authored
Reduce flakiness in OtelSpringStarterSmokeTest.shouldSendTelemetry() (#18476)
1 parent 9297006 commit 787e9fc

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

smoke-tests-otel-starter/spring-boot-common/src/main/java/io/opentelemetry/spring/smoketest/AbstractOtelSpringStarterSmokeTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ protected void assertAdditionalMetrics() throws InterruptedException, TimeoutExc
291291

292292
double javaVersion = Double.parseDouble(System.getProperty("java.specification.version"));
293293
// JFR based metrics
294+
// Note: jvm.network.io is intentionally omitted because it is flaky across all JDK versions.
294295
for (String metric :
295296
asList(
296297
"jvm.cpu.count",
@@ -303,12 +304,9 @@ protected void assertAdditionalMetrics() throws InterruptedException, TimeoutExc
303304
"jvm.memory.init",
304305
"jvm.memory.used",
305306
"jvm.memory.allocation",
306-
"jvm.network.io",
307307
"jvm.thread.count")) {
308308
// cpu longlock is missing on jdk 25
309-
// jvm.network.io is flaky on jdk 25
310-
if (javaVersion >= 25
311-
&& ("jvm.cpu.longlock".equals(metric) || "jvm.network.io".equals(metric))) {
309+
if (javaVersion >= 25 && "jvm.cpu.longlock".equals(metric)) {
312310
continue;
313311
}
314312
testing.waitAndAssertMetrics(

0 commit comments

Comments
 (0)