Skip to content

Commit 7ac7290

Browse files
committed
revert
1 parent 499fdc9 commit 7ac7290

2 files changed

Lines changed: 7 additions & 4 deletions

File tree

.github/agents/knowledge/gradle-conventions.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,13 @@ Flag `build.gradle.kts` dependencies that appear unused or redundant:
157157
- A dependency that duplicates something already provided transitively.
158158
- A `testImplementation` dependency for a library not used in tests.
159159

160+
### Never declare `javaagent-bootstrap` explicitly in javaagent modules
161+
162+
The `otel.javaagent-instrumentation` convention plugin already provides
163+
`javaagent-bootstrap` on the `compileOnly` classpath transitively. Do not add
164+
`compileOnly(project(":javaagent-bootstrap"))` to a javaagent module's
165+
`build.gradle.kts`, and remove it if present.
166+
160167
## Custom Test Tasks
161168

162169
Every custom `Test` task registered with `val foo by registering(Test::class)` **must** include

instrumentation/internal/internal-eclipse-osgi-3.6/javaagent/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ plugins {
22
id("otel.javaagent-instrumentation")
33
}
44

5-
dependencies {
6-
compileOnly(project(":javaagent-bootstrap"))
7-
}
8-
95
// this instrumentation applies to the class 'org.eclipse.osgi.internal.loader.BundleLoader'
106
// which is present in the following artifacts dating back to version 3.6 (2010):
117
//

0 commit comments

Comments
 (0)