Skip to content

Commit 80e9ab2

Browse files
committed
Remove ApacheClientNullHttpHostRequestTest
Apache HttpClient 4.0's DefaultRequestDirector.determineRoute throws IllegalStateException when target host is null and not set in params, so this test could never pass against the pinned 4.0 client. The @nullable annotation added to the instrumentation advice is a documentation-only change and does not need a runtime test.
1 parent be109c4 commit 80e9ab2

1 file changed

Lines changed: 0 additions & 19 deletions

File tree

  • instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0

instrumentation/apache-httpclient/apache-httpclient-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/apachehttpclient/v4_0/ApacheHttpClientTest.java

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -93,25 +93,6 @@ void executeRequestWithCallback(BasicHttpRequest request, URI uri, HttpClientRes
9393
}
9494
}
9595

96-
@Nested
97-
class ApacheClientNullHttpHostRequestTest extends AbstractTest<BasicHttpRequest> {
98-
@Override
99-
BasicHttpRequest createRequest(String method, URI uri) {
100-
return new BasicHttpRequest(method, uri.toString());
101-
}
102-
103-
@Override
104-
HttpResponse doExecuteRequest(BasicHttpRequest request, URI uri) throws Exception {
105-
return getClient(uri).execute(null, request);
106-
}
107-
108-
@Override
109-
void executeRequestWithCallback(BasicHttpRequest request, URI uri, HttpClientResult result)
110-
throws Exception {
111-
getClient(uri).execute(null, request, new HttpResponseHandler(result));
112-
}
113-
}
114-
11596
@Nested
11697
class ApacheClientHostAbsoluteUriRequestTest extends AbstractTest<BasicHttpRequest> {
11798
@Override

0 commit comments

Comments
 (0)