Skip to content

Commit b4903c1

Browse files
authored
Review fixes for jetty-httpclient-9.2:library (#18083)
Co-authored-by: otelbot <197425009+otelbot@users.noreply.github.com>
1 parent d55a9af commit b4903c1

3 files changed

Lines changed: 5 additions & 6 deletions

File tree

instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyClientHttpAttributesGetter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
1919
* any time.
2020
*/
21-
public class JettyClientHttpAttributesGetter
22-
implements HttpClientAttributesGetter<Request, Response> {
21+
class JettyClientHttpAttributesGetter implements HttpClientAttributesGetter<Request, Response> {
2322

2423
@Override
2524
@Nullable

instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyClientTracingListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public final class JettyClientTracingListener
3333

3434
private static final Logger logger = Logger.getLogger(JettyClientTracingListener.class.getName());
3535

36-
private static final Class<?>[] requestlistenerInterfaces = {
36+
private static final Class<?>[] REQUEST_LISTENER_INTERFACES = {
3737
Request.BeginListener.class,
3838
Request.FailureListener.class,
3939
Request.SuccessListener.class,
@@ -89,7 +89,7 @@ private static void wrapRequestListeners(
8989

9090
Class<?> listenerClass = listener.getClass();
9191

92-
for (Class<?> type : requestlistenerInterfaces) {
92+
for (Class<?> type : REQUEST_LISTENER_INTERFACES) {
9393
if (type.isInstance(listener)) {
9494
interfaces.add(type);
9595
}

instrumentation/jetty-httpclient/jetty-httpclient-9.2/library/src/main/java/io/opentelemetry/instrumentation/jetty/httpclient/v9_2/internal/JettyClientWrapUtil.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
*/
2323
public final class JettyClientWrapUtil {
2424

25-
private static final Class<?>[] listenerInterfaces = buildListenerInterfaces();
25+
private static final Class<?>[] LISTENER_INTERFACES = buildListenerInterfaces();
2626

2727
private static Class<?>[] buildListenerInterfaces() {
2828
List<Class<?>> interfaces =
@@ -74,7 +74,7 @@ private static Response.ResponseListener wrapTheListener(
7474

7575
Class<?> listenerClass = listener.getClass();
7676
List<Class<?>> interfaces = new ArrayList<>();
77-
for (Class<?> type : listenerInterfaces) {
77+
for (Class<?> type : LISTENER_INTERFACES) {
7878
if (type.isInstance(listener)) {
7979
interfaces.add(type);
8080
}

0 commit comments

Comments
 (0)