Skip to content

Commit bc533f6

Browse files
SylvainJugetrask
andauthored
fix tomcat error valve classes visibility (#16243)
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
1 parent dbb5e34 commit bc533f6

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

  • instrumentation/tomcat
    • tomcat-10.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/tomcat/v10_0
    • tomcat-7.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/tomcat/v7_0

instrumentation/tomcat/tomcat-10.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/tomcat/v10_0/ErrorHandlerValve.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
import org.apache.catalina.connector.Response;
1111
import org.apache.catalina.valves.ErrorReportValve;
1212

13-
class ErrorHandlerValve extends ErrorReportValve {
13+
// public, because it's loaded by reflection
14+
public class ErrorHandlerValve extends ErrorReportValve {
1415
@Override
1516
protected void report(Request request, Response response, Throwable t) {
1617
if (response.getStatus() < 400 || response.getContentWritten() > 0 || !response.isError()) {

instrumentation/tomcat/tomcat-7.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/tomcat/v7_0/ErrorHandlerValve.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,8 @@
1010
import org.apache.catalina.connector.Response;
1111
import org.apache.catalina.valves.ErrorReportValve;
1212

13-
class ErrorHandlerValve extends ErrorReportValve {
13+
// public, because it's loaded by reflection
14+
public class ErrorHandlerValve extends ErrorReportValve {
1415
@Override
1516
protected void report(Request request, Response response, Throwable t) {
1617
if (response.getStatus() < 400 || response.getContentWritten() > 0 || !response.isError()) {

0 commit comments

Comments
 (0)